New issue
Advanced search Search tips

Issue 705367 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Gamepad


Sign in to add a comment

"GamepadProviderTest.PollingAccess" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 27 2017

Issue description

"GamepadProviderTest.PollingAccess" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFHYW1lcGFkUHJvdmlkZXJUZXN0LlBvbGxpbmdBY2Nlc3MM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by kolos@chromium.org, Mar 27 2017

Owner: scottmg@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f988185f6973f485ef5aeed2cc1b6e38797359bd

commit f988185f6973f485ef5aeed2cc1b6e38797359bd
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 08:41:36 2017

Disable flaky GamepadProviderTest.PollingAccess test

TBR=scottmg
BUG= 705367 

Review-Url: https://codereview.chromium.org/2778673002
Cr-Commit-Position: refs/heads/master@{#459723}

[modify] https://crrev.com/f988185f6973f485ef5aeed2cc1b6e38797359bd/device/gamepad/gamepad_provider_unittest.cc

Comment 3 by kolos@chromium.org, Mar 27 2017

Labels: -Sheriff-Chromium
Cc: scottmg@chromium.org
Components: IO>Gamepad
Owner: mattreynolds@chromium.org
Status: Fixed (was: Assigned)
I think this is fixed by https://codereview.chromium.org/2820563003, marking as Fixed and reenabling the test on all platforms.

I hadn't seen this fail before, but I think it is likely caused by the same race condition as  crbug.com/692219 . I ran the patched unittest 1000x on OSX, Linux, and Android and saw no failures.  That said, I hadn't seen any failures prior to the change.

Please reopen if this test is still flaky!
Components: -IO>Gamepad Blink>GamepadAPI

Sign in to add a comment