New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Ghost text doesn't appear in search text field in chrome://md-settings/languages.

Reported by rp...@etouch.net, Mar 27 2017

Issue description

Version: 59.0.3053.0 bba05f44fe583ffa69c22d36f91aaebe0ceea282-refs/heads/master@{#459685}
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/languages 
2. Now expand it and click on 'Add languages' to open overlay and observe search field

Actual: Ghost text doesn't appear in search text field
Expected: Ghost text should appear in search text field

This is a non-regression issue, seen from M-59 series as 'search field' in 'Add languages' overlay appears from build # 59.0.3051.3 

Kindly review the attached screen cast and video for reference.
 
Actual_screenshot.png
162 KB View Download
Expected_screenshot.png
169 KB View Download
Status: Untriaged (was: Unconfirmed)
Untriaged, so that it gets addressed.

Comment 2 by dpa...@chromium.org, Apr 12 2018

Cc: aee@chromium.org
Status: Available (was: Untriaged)
We should probably add a "Search languages" placeholder text.

Comment 3 by aee@chromium.org, Apr 20 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fef3dbbb4c0213c37259b9d6a07e2363ebe6a005

commit fef3dbbb4c0213c37259b9d6a07e2363ebe6a005
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Apr 20 20:57:44 2018

Settings: show placeholder text in search field for the add language dialog

Bug:  705359 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I267391af9bc7bab6fa3c9e5e86f326534ac6ae93
Reviewed-on: https://chromium-review.googlesource.com/1022371
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552465}
[modify] https://crrev.com/fef3dbbb4c0213c37259b9d6a07e2363ebe6a005/chrome/app/settings_strings.grdp
[modify] https://crrev.com/fef3dbbb4c0213c37259b9d6a07e2363ebe6a005/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/fef3dbbb4c0213c37259b9d6a07e2363ebe6a005/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 5 by aee@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

Comment 6 by rp...@etouch.net, Apr 23 2018

Labels: TE-Verified-68.0.3404.0 TE-Verified-M68
Update : 
Retested above issue in latest Canary build #68.0.3404.0 on Windows(7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.5)OS and the issue is fixed.Kindly review an attached screen-cast.

Thank you..!
Fixed_behaviour.mp4
182 KB View Download

Sign in to add a comment