Issue metadata
Sign in to add a comment
|
Can't implement custom accessible actions on a view |
||||||||||||||||||||||||
Issue descriptionView::HandleAccessibleAction won't be called when using ChromeVox. For example, when a user presses Search+Space, hard-coded mouse pressing and releasing events are always fired. (https://cs.chromium.org/chromium/src/ui/views/accessibility/ax_view_obj_wrapper.cc?l=66). Is it ok to change this behavior to try View::HandleAccessibleAction first then do the default action if it returns false?
,
Mar 27 2017
> View::HandleAccessibleAction won't be called when using ChromeVox I'd be up for fixing that. Let's move most of the code from ax_view_obj_wrapper.cc to View::HandleAccessibleAction In the few cases where that doesn't make sense, ax_view_obj_wrapper.cc should call View first and only handle it if the View returns null. Want to make this change? What's the specific use-case where you wanted to override the action on a View, by the way?
,
Mar 28 2017
,
Mar 28 2017
I've created an experimental change (crrev.com/2767143007). It seems to pass the tests at least. Could you take a look at it? I tried to provide expanding/collapsing action on ARC notifications. It expands when a user presses Search+Space on an expandable notification first time. If the user presses Search+Space once more, it opens.
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e80b960e27af6495ff3dd79cbfcede18d48da85a commit e80b960e27af6495ff3dd79cbfcede18d48da85a Author: yhanada <yhanada@chromium.org> Date: Wed Mar 29 01:00:51 2017 Try |View::HandleAccessibleAction| before falling back to fixed actions. Currently automation API always do the fixed action for each accessible action. For example, clicking on the center of the target view is always triggered when AX_ACTION_DO_DEFAULT is passed to automation API. This CL makes automation API try to use |View::HandleAccessibleAction| first. This change enables us to implement custom action on accessible actions. BUG= 705350 Review-Url: https://codereview.chromium.org/2767143007 Cr-Commit-Position: refs/heads/master@{#460255} [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.h [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/ui/views/BUILD.gn [add] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/ui/views/accessibility/ax_aura_obj_wrapper.cc [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/ui/views/accessibility/ax_aura_obj_wrapper.h [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/ui/views/accessibility/ax_view_obj_wrapper.cc [modify] https://crrev.com/e80b960e27af6495ff3dd79cbfcede18d48da85a/ui/views/accessibility/ax_view_obj_wrapper.h
,
Mar 29 2017
,
May 30 2017
,
Jul 6 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Mar 27 2017