Count the impressions for Dialog boxes on Views, starting with Translate. For more detail see: go/dialog-impressions
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45 commit 7872d6c00ef5493bb8abdbf5c33a62d82d2fde45 Author: pdyson <pdyson@chromium.org> Date: Wed Apr 05 23:12:31 2017 Function to count dialog box creations. Create a function to count dialog box creations and use it to log translate. Future CLs will add this logging to other dialog boxes. BUG= 705331 Review-Url: https://codereview.chromium.org/2790723004 Cr-Commit-Position: refs/heads/master@{#462260} [modify] https://crrev.com/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45/chrome/browser/ui/BUILD.gn [add] https://crrev.com/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45/chrome/browser/ui/browser_dialogs.cc [modify] https://crrev.com/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/7872d6c00ef5493bb8abdbf5c33a62d82d2fde45/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535 commit a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535 Author: pdyson <pdyson@chromium.org> Date: Thu Apr 20 00:00:15 2017 Log creation of many dialog box types. Expand the logging introduced in codereview.chromium.org/2790723004 to include more dialog boxes that are of interest for DPM. BUG= 705331 Review-Url: https://codereview.chromium.org/2802703004 Cr-Commit-Position: refs/heads/master@{#465816} [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/confirm_bubble_views.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/conflicting_module_view_win.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/critical_notification_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/crypto_module_password_dialog_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/download/download_feedback_dialog_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/first_run_bubble.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/hung_renderer_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/network_profile_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/session_crashed_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/chrome/browser/ui/views/update_recommended_message_box.cc [modify] https://crrev.com/a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/106455b2f89608b7225f03fe71593332aa4eddfe commit 106455b2f89608b7225f03fe71593332aa4eddfe Author: pdyson <pdyson@chromium.org> Date: Wed Apr 26 01:21:31 2017 Log the creation of more dialog box types. Increase the number of dialog box types that have their creation logged. These are simple cases, where the logging is in the constructor. Future cls will include more complex cases. BUG= 705331 Review-Url: https://codereview.chromium.org/2833603003 Cr-Commit-Position: refs/heads/master@{#467195} [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/autofill/save_card_bubble_views.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/global_error_bubble_view.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc [modify] https://crrev.com/106455b2f89608b7225f03fe71593332aa4eddfe/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18c894ab917e7396857d10d247c278fc6f2e5c0f commit 18c894ab917e7396857d10d247c278fc6f2e5c0f Author: pdyson <pdyson@chromium.org> Date: Thu May 04 01:11:22 2017 Log the creation of a dialog boxes using DialogDelegate. BUG= 705331 Review-Url: https://codereview.chromium.org/2850533003 Cr-Commit-Position: refs/heads/master@{#469226} [modify] https://crrev.com/18c894ab917e7396857d10d247c278fc6f2e5c0f/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/18c894ab917e7396857d10d247c278fc6f2e5c0f/ui/views/window/dialog_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/918928e65b775182d50ea33ac24d45e9501e7e82 commit 918928e65b775182d50ea33ac24d45e9501e7e82 Author: pdyson <pdyson@chromium.org> Date: Thu May 04 03:50:12 2017 Log the creation of Sign In related dialog boxes. BUG= 705331 Review-Url: https://codereview.chromium.org/2840483002 Cr-Commit-Position: refs/heads/master@{#469264} [modify] https://crrev.com/918928e65b775182d50ea33ac24d45e9501e7e82/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/918928e65b775182d50ea33ac24d45e9501e7e82/chrome/browser/ui/signin_view_controller.cc [modify] https://crrev.com/918928e65b775182d50ea33ac24d45e9501e7e82/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/918928e65b775182d50ea33ac24d45e9501e7e82/chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc [modify] https://crrev.com/918928e65b775182d50ea33ac24d45e9501e7e82/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe27ed665852a667acdba62f8a77a1d9969170da commit fe27ed665852a667acdba62f8a77a1d9969170da Author: pdyson <pdyson@chromium.org> Date: Fri May 12 00:18:20 2017 Log the creation of dialog boxes using DialogDelegateView and BubbleDialogDelegateView. BUG= 705331 Review-Url: https://codereview.chromium.org/2867683002 Cr-Commit-Position: refs/heads/master@{#471137} [modify] https://crrev.com/fe27ed665852a667acdba62f8a77a1d9969170da/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/fe27ed665852a667acdba62f8a77a1d9969170da/ui/views/bubble/bubble_dialog_delegate.cc [modify] https://crrev.com/fe27ed665852a667acdba62f8a77a1d9969170da/ui/views/window/dialog_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d06138094fbdff17a1a18e4bc933bddf87732ab5 commit d06138094fbdff17a1a18e4bc933bddf87732ab5 Author: pdyson <pdyson@chromium.org> Date: Mon May 15 04:09:03 2017 Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create. BUG= 705331 Review-Url: https://codereview.chromium.org/2868203002 Cr-Commit-Position: refs/heads/master@{#471660} [modify] https://crrev.com/d06138094fbdff17a1a18e4bc933bddf87732ab5/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/d06138094fbdff17a1a18e4bc933bddf87732ab5/ui/views/window/dialog_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fa1d036e427d6a1fca97f8d954835d8d7220986 commit 7fa1d036e427d6a1fca97f8d954835d8d7220986 Author: pdyson <pdyson@chromium.org> Date: Wed May 17 23:54:45 2017 Log the creation of several more dialog box types. BUG= 705331 Review-Url: https://codereview.chromium.org/2881683002 Cr-Commit-Position: refs/heads/master@{#472604} [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/attestation/platform_verification_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/enrollment_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/external_protocol_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/options/network_config_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/ui/echo_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/chromeos/ui/request_pin_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/accessibility/invert_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/arc_app_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/collected_cookies_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/content_setting_bubble_contents.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/create_application_shortcut_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/download/download_danger_prompt_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/download/download_in_progress_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/extensions/chooser_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/extensions/extension_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/extensions/extension_popup_aura.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/external_protocol_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/first_run_dialog.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/importer/import_lock_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/intent_picker_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/login_handler_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/platform_keys_certificate_selector_chromeos.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/profiles/user_manager_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/simple_message_box_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/ssl_client_certificate_selector.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/task_manager_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/toolbar/home_button.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/validation_message_bubble_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc [modify] https://crrev.com/7fa1d036e427d6a1fca97f8d954835d8d7220986/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8492c80df9a9652fbacbc30d08e83b18573ce564 commit 8492c80df9a9652fbacbc30d08e83b18573ce564 Author: Paul Dyson <pdyson@chromium.org> Date: Wed Aug 16 01:02:07 2017 Record the time that dialog boxes are open. This histogram covers dialog boxes generated using the parent class DialogDelegate. Bug: 705331 Change-Id: I325096d1ea76d8080c544121a2506da68c6af697 Reviewed-on: https://chromium-review.googlesource.com/604637 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#494647} [modify] https://crrev.com/8492c80df9a9652fbacbc30d08e83b18573ce564/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/8492c80df9a9652fbacbc30d08e83b18573ce564/ui/views/window/dialog_delegate.cc [modify] https://crrev.com/8492c80df9a9652fbacbc30d08e83b18573ce564/ui/views/window/dialog_delegate.h
Comment 1 by yyushkina@chromium.org
, Apr 3 2017