New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705310 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
OOO until July 2018
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 703887


Participants' hotlists:
Clingon-translate


Sign in to add a comment

Create translate_compact_infobar, a new native class for the new translate UI

Project Member Reported by ramyasharma@chromium.org, Mar 27 2017

Issue description

Create translate_compact_infobar class, which holds the logic for the new translate UI in the native code, and calls the new Translate infobar in Android UI.

 
Labels: -Type-Bug Type-Feature
This is a sub-bug of a bigger umbrella bug: https://bugs.chromium.org/p/chromium/issues/detail?id=703887. See parent bug for more details.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4

commit 5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4
Author: ramyasharma <ramyasharma@chromium.org>
Date: Tue Mar 28 03:40:01 2017

Creates translate_compact_infobar class, which holds the logic for the new translate UI.

This translate_compact_infobar is created in the native code, and calls the
new Translate infobar in Android UI.

BUG= 705310 
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2762393003
Cr-Commit-Position: refs/heads/master@{#460002}

[modify] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/BUILD.gn
[modify] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/android/chrome_jni_registrar.cc
[add] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/translate/android/translate_utils.cc
[add] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/translate/android/translate_utils.h
[modify] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[add] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/ui/android/infobars/translate_compact_infobar.h
[modify] https://crrev.com/5f3bcbb0eae7cb2aaf21bd7cc025c86a82d595d4/chrome/browser/ui/android/infobars/translate_infobar.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81

commit da825a1f6e9d71bf54d5832ccacb3b718eaa6f81
Author: ramyasharma <ramyasharma@chromium.org>
Date: Tue Apr 18 02:28:51 2017

Implements ApplyTranslateOptions in compact infobar

Introduces a new enum to capture all possible data
that java frontend will save on the native side.
And uses this enum, as a parameter passed
to ApplyStringTranslateOptions and
ApplyBoolTranslateOptions, along with it's value.
Value is boolean or string based on the method
called.

BUG= 705310 
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2799083004
Cr-Commit-Position: refs/heads/master@{#465102}

[modify] https://crrev.com/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81/chrome/android/BUILD.gn
[modify] https://crrev.com/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81/chrome/browser/translate/android/translate_utils.h
[modify] https://crrev.com/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/da825a1f6e9d71bf54d5832ccacb3b718eaa6f81/chrome/browser/ui/android/infobars/translate_compact_infobar.h

Status: Fixed (was: Assigned)
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment