New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705242 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

long press on link doesn't show link URL

Project Member Reported by dbloch@google.com, Mar 25 2017

Issue description

Device name: Pixel
Application version: Chrome Canary 59.0.3050.4
Operating system: Android 7.0.99

Steps to reproduce:
(1) long press on a link

Expected result:
Menu appears showing link's URL and various options: Open in new tab, Open in incognito tab, etc.

Actual result:
Menu appears with options, but the URL isn't there.

This happens in the latest canary.  It doesn't happen in earlier releases.




 
Labels: ReleaseBlock-Beta M-59
Owner: jwanda@chromium.org
Status: Assigned (was: Unconfirmed)
Good build: 59.0.3049.0
Bad build: 59.0.3050.0
Regression range: https://chromium.googlesource.com/chromium/src/+log/59.0.3049.0..59.0.3050.0?pretty=fuller&n=10000

Good commit: 459239
Bad commit: 459240
Culprit CL: https://chromium.googlesource.com/chromium/src/+/bbe38f7faddf00596f655c1d66d65814784ed642

jwanda@, can you please take a look?  Thanks.
Labels: -Pri-3 Pri-1 Type-Bug-Regression
 Issue 705219  has been merged into this issue.

Comment 4 by jwanda@chromium.org, Mar 27 2017

Status: Started (was: Assigned)
Taking a look.

Comment 5 by jwanda@chromium.org, Mar 27 2017

Do you have a link that I can take a look at? I can't reproduce this error.

Comment 6 by jwanda@chromium.org, Mar 27 2017

Nevermind, I was working on an old CL. I see the problem.

Comment 7 by jwanda@chromium.org, Mar 27 2017

Found it and fixing it: https://codereview.chromium.org/2779543004/

Comment 8 by jwanda@chromium.org, Mar 27 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bb5696626414f0b955c9dedb8552fe8df09cb26

commit 3bb5696626414f0b955c9dedb8552fe8df09cb26
Author: jwanda <jwanda@chromium.org>
Date: Mon Mar 27 21:35:58 2017

Follow up to empty text header

I quite literally don't know how this went through as I checked my other
branch and it had this in. So I'm a little confused on what happened as
I'm 100% sure I did a cl upload. Regardless this silently went in and as
a result this is a quick way to fix it.

BUG= 705242 

Review-Url: https://codereview.chromium.org/2779543004
Cr-Commit-Position: refs/heads/master@{#459888}

[modify] https://crrev.com/3bb5696626414f0b955c9dedb8552fe8df09cb26/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

Comment 10 by mar...@mwiacek.com, Mar 28 2017

in this situation I'm deleting my exactly the same fix, which was waiting for review from Saturday :)

https://codereview.chromium.org/2779473002/
Cc: mlamouri@chromium.org tedc...@chromium.org
 Issue 704463  has been merged into this issue.

Sign in to add a comment