New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705233 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 682393
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Context menu doesn't display URL without '%'-escaped chars

Project Member Reported by mar...@mwiacek.com, Mar 25 2017

Issue description

Steps to reproduce the problem:
1. open ContextMenu

What is the expected behavior?
Displayed URL is as simple as possible

What went wrong?
URL contains '%'-escaped chars

Did this work before? No 

Chrome version: 59  Channel: canary
OS Version: 7
Flash Version:

 

Comment 1 by mar...@mwiacek.com, Mar 25 2017

Proposed patch https://codereview.chromium.org/2774143002/
Screenshot_20170325-204825[1].png
225 KB View Download
Cc: sandeepkumars@chromium.org
Labels: Needs-triage-Mobile Needs-Feedback
@marcin: Thanks for the report!!

Are you still able to reproduce the issue in the latest Chrome builds? If so please help us with the details of your device to check the issue from our end.

Thanks!!

Comment 3 by mar...@mwiacek.com, Nov 20 2017

> @marcin: Thanks for the report!!
> Are you still able to reproduce the issue in the latest Chrome builds? 
> If so please help us with the details of your device to 
> check the issue from our end.
> Thanks!!

Changes related to % chars were put on hold from unknown for me reason: https://bugs.chromium.org/p/chromium/issues/detail?id=682393

Yes, problem is still visible and valid.
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 20 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sandeepkumars@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Triaged-Mobile
Mergedinto: 682393
Status: Duplicate (was: Unconfirmed)
This issue seems to be a dupe of  issue 682393 , hence duping into it, un dupe if not the case

Thanks!!

Comment 6 by mar...@mwiacek.com, Dec 20 2017

682393 and 705233 are related to totally different app places and can be differently handled, please unduplicate.
Status: Unconfirmed (was: Duplicate)
As per comment #6 un duping the issue, and requesting UI team for further triaging of the issue as we weren't able to reproduce the issue.

Thanks!!

Comment 8 by mar...@mwiacek.com, Feb 8 2018

Owner: mar...@mwiacek.com
Status: Assigned (was: Unconfirmed)

Comment 9 by mar...@mwiacek.com, May 6 2018

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Project Member

Comment 11 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c338d326d20d1d24ab987320b1a5323976314d1

commit 5c338d326d20d1d24ab987320b1a5323976314d1
Author: Marcin Wiacek <marcin@mwiacek.com>
Date: Sat May 19 22:05:16 2018

Align Context Menu in Android Chrome to desktop/FF

Desktop Chrome / Firefox are decoding % sequences in URLs in the
status bar, additionally desktop Chrome is omitting HTTP scheme there.

Patch is including this functionality in the Android Chrome
in the context menu URL and is replacing or extending:

1. crrev.com/2774143002/
2. https://chromium-review.googlesource.com/c/chromium/src/+/877759
3. https://chromium-review.googlesource.com/c/chromium/src/+/1015229

BUG= 705233 

Change-Id: I70509448108e267b66413a9c8869518706375b68
Reviewed-on: https://chromium-review.googlesource.com/1037123
Commit-Queue: Marcin WiÄ…cek <marcin@mwiacek.com>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560182}
[modify] https://crrev.com/5c338d326d20d1d24ab987320b1a5323976314d1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/5c338d326d20d1d24ab987320b1a5323976314d1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
[modify] https://crrev.com/5c338d326d20d1d24ab987320b1a5323976314d1/components/url_formatter/android/java/src/org/chromium/components/url_formatter/UrlFormatter.java
[modify] https://crrev.com/5c338d326d20d1d24ab987320b1a5323976314d1/components/url_formatter/url_formatter_android.cc

Comment 12 by mar...@mwiacek.com, May 21 2018

Status: fixed (was: Assigned)

Sign in to add a comment