New issue
Advanced search Search tips

Issue 705225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PaymentRequestCanMakePaymentQueryTest.CanMakePayment_Supported" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 25 2017

Issue description

"PaymentRequestCanMakePaymentQueryTest.CanMakePayment_Supported" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5QYXltZW50UmVxdWVzdENhbk1ha2VQYXltZW50UXVlcnlUZXN0LkNhbk1ha2VQYXltZW50X1N1cHBvcnRlZAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by kolos@chromium.org, Mar 27 2017

Owner: ma...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac17bb0e7400891b2954b961825140f7d6ab3f66

commit ac17bb0e7400891b2954b961825140f7d6ab3f66
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 10:19:08 2017

Disable flaky PaymentRequestCanMakePaymentQueryTest.CanMakePayment_Supported

TBR=mathp@chromium.org
BUG= 705225 

Review-Url: https://codereview.chromium.org/2774253002
Cr-Commit-Position: refs/heads/master@{#459742}

[modify] https://crrev.com/ac17bb0e7400891b2954b961825140f7d6ab3f66/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc

Comment 3 by kolos@chromium.org, Mar 27 2017

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87f43df763144d0a107571a9fc850f1df558776

commit d87f43df763144d0a107571a9fc850f1df558776
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 12:44:31 2017

Disable flaky CanMakePayment_Supported and CanMakePayment_NotSupported_Incognito (PaymentRequestCanMakePaymentQueryTest) for all platforms

TBR=mathp@chromium.org
BUG= 705271 , 705225 

Review-Url: https://codereview.chromium.org/2772263002
Cr-Commit-Position: refs/heads/master@{#459762}

[modify] https://crrev.com/d87f43df763144d0a107571a9fc850f1df558776/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc

 Issue 705585  has been merged into this issue.
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Mar 28 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "PaymentRequestCanMakePaymentQueryTest.CanMakePayment_Supported". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5QYXltZW50UmVxdWVzdENhbk1ha2VQYXltZW50UXVlcnlUZXN0LkNhbk1ha2VQYXltZW50X1N1cHBvcnRlZAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 7 by hayato@chromium.org, Mar 28 2017

Labels: -Sheriff-Chromium

Comment 8 by ma...@chromium.org, Mar 28 2017

Status: Fixed (was: Assigned)
Fixed in https://codereview.chromium.org/2775193004/

Sign in to add a comment