New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705224 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"DownloadTest.FeedbackServiceKeepDownload" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 25 2017

Issue description

"DownloadTest.FeedbackServiceKeepDownload" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihEb3dubG9hZFRlc3QuRmVlZGJhY2tTZXJ2aWNlS2VlcERvd25sb2FkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by kolos@chromium.org, Mar 27 2017

Cc: nparker@chromium.org
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5cf7525216f3ee676a01cb651d3457d9eb8fcdb

commit c5cf7525216f3ee676a01cb651d3457d9eb8fcdb
Author: kolos <kolos@chromium.org>
Date: Mon Mar 27 11:20:11 2017

Disable flaky DownloadTest.FeedbackServiceKeepDownload

TBR=jialiul@chromium.org
BUG= 705224 

Review-Url: https://codereview.chromium.org/2777093002
Cr-Commit-Position: refs/heads/master@{#459754}

[modify] https://crrev.com/c5cf7525216f3ee676a01cb651d3457d9eb8fcdb/chrome/browser/download/download_browsertest.cc

Comment 3 by kolos@chromium.org, Mar 27 2017

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e417c028e62d771638997c4545a359ba93027ec

commit 0e417c028e62d771638997c4545a359ba93027ec
Author: jialiul <jialiul@chromium.org>
Date: Thu Mar 30 21:46:19 2017

Fix flaky DownloadTest.FeedbackServiceKeepDownload

BUG= 705224 

Review-Url: https://codereview.chromium.org/2778853002
Cr-Commit-Position: refs/heads/master@{#460894}

[modify] https://crrev.com/0e417c028e62d771638997c4545a359ba93027ec/chrome/browser/download/download_browsertest.cc

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbadcddfb7adac0f013ff2522647f78c19088c5b

commit cbadcddfb7adac0f013ff2522647f78c19088c5b
Author: jialiul <jialiul@chromium.org>
Date: Fri Mar 31 16:26:09 2017

Revert of Fix flaky DownloadTest.FeedbackServiceKeepDownload (patchset #2 id:20001 of https://codereview.chromium.org/2778853002/ )

Reason for revert:
Should use DownloadTestObserverTerminal instead.

Original issue's description:
> Fix flaky DownloadTest.FeedbackServiceKeepDownload
>
> BUG= 705224 
>
> Review-Url: https://codereview.chromium.org/2778853002
> Cr-Commit-Position: refs/heads/master@{#460894}
> Committed: https://chromium.googlesource.com/chromium/src/+/0e417c028e62d771638997c4545a359ba93027ec

TBR=dtrainor@chromium.org,qinmin@chromium.org,asanka@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 705224 

Review-Url: https://codereview.chromium.org/2786103005
Cr-Commit-Position: refs/heads/master@{#461143}

[modify] https://crrev.com/cbadcddfb7adac0f013ff2522647f78c19088c5b/chrome/browser/download/download_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf73243bf9eb70d813d800f9b4e49df688452b80

commit bf73243bf9eb70d813d800f9b4e49df688452b80
Author: jialiul <jialiul@chromium.org>
Date: Sat Apr 01 00:32:21 2017

Fix flaky DownloadTest.FeedbackServiceKeepDownload

BUG= 705224 

Review-Url: https://codereview.chromium.org/2778853002
Cr-Original-Commit-Position: refs/heads/master@{#460894}
Committed: https://chromium.googlesource.com/chromium/src/+/0e417c028e62d771638997c4545a359ba93027ec
Review-Url: https://codereview.chromium.org/2778853002
Cr-Commit-Position: refs/heads/master@{#461287}

[modify] https://crrev.com/bf73243bf9eb70d813d800f9b4e49df688452b80/chrome/browser/download/download_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment