take screenshot at multiple dppx resolution
Reported by
pdk...@gmail.com,
Mar 25 2017
|
|||
Issue descriptionChrome Version: 57.0.2987.93 The device toolbar has an option to capture a screenshot, which does as advertised. It'd be very useful if DPR was taken into account. Example: Set device resolution to 500x500 and DPR to 2. Take screenshot. If you have done so on a 1x device (such as a regular monitor), the screenshot taken is 500x500. Instead it should be 1000x1000, as rendered on a 2x device. Or 1500x1500 when DPR is set to 3. In addition, an option perhaps titled Capture Page should be added, which takes a screenshot of the whole page. This can already be done through other means, but not with DPR taken into account.
,
Mar 25 2017
me too
,
Mar 27 2017
,
Mar 27 2017
This would be really hard to implement, since we render on the host device with DPR being the host one. See issue 638281 for full-page.
,
Apr 29 2017
I was surprised to notice that FF implements this.
,
Oct 4 2017
This is actually fixed - we now do special preparation before capturing screenshots, so it gets DPR of emulated device.
,
Oct 5 2017
Do you have a CL? Just want to know into which release this got.
,
Oct 5 2017
This is a revision: https://chromium.googlesource.com/chromium/src/+/bd74faae21bebdda0da67016c2977b4ce85fcef0 It went into version 61.
,
Oct 5 2017
Works! I was still on an earlier version. What I noticed is that it briefly flashes the cropped page rendered at higher DPR when it takes the screenshot. It's merely a cosmetic issue, so perhaps not worth mentioning, and probably unavoidable. PS. May I suggest a common prefix for the downloaded files, like chrome-%s or the like. Easier to group. And perhaps a hash as suffix, rather than numbering them like duplicates. |
|||
►
Sign in to add a comment |
|||
Comment 1 by phistuck@chromium.org
, Mar 25 2017Labels: -Type-Bug OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Type-Feature
Status: Untriaged (was: Unconfirmed)