New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705194 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Pick up WP2 firmware fix for 'FW error in SYNC CMD TIME_EVENT_CMD'

Project Member Reported by kirtika@chromium.org, Mar 25 2017

Issue description

OS: R58

Luca from Intel provided a WP2 firmware fix here: https://chromium-review.googlesource.com/#/c/459098/
This gets us to the same version as upstream, which we were missing
earlier since WP2 firmware development stopped at Core14. 

From the upstream bug, the below seems like the symptom this fixes.
 
iwlwifi 0000:03:00.0: loaded firmware version 17.352738.0 op_mode iwlmvm
iwlwifi 0000:03:00.0: Microcode SW error detected.  Restarting 0x2000000.
iwlwifi 0000:03:00.0: FW error in SYNC CMD TIME_EVENT_CMD
WARNING: CPU: 0 PID: 31459 at 
drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1377 iwl_mvm_rx_tx_cmd+0x662/0x870 [iwlmvm]
WARNING: CPU: 0 PID: 28749 at drivers/net/wireless/intel/iwlwifi/mvm/utils.c:679 iwl_mvm_enable_txq+0x228/0x2a0 [iwlmvm]


This bug is to track:
- digging up feedback report logs to check how prevalent this has
been for Chrome OS.
- test and recommend cherry-picking to M58, which still has a month in beta. 


 
Cc: bhthompson@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+/692acdad625db46232ae704651befa9d9e2e536f

commit 692acdad625db46232ae704651befa9d9e2e536f
Author: Luca Coelho <luciano.coelho@intel.com>
Date: Sat Mar 25 10:51:12 2017

iwl7000: add new -17.ucode for 7260

We have delivered a new version of the 7260 firmware for upstream with
a bugfix.  Align the ChromeOS version to it.

The fix is for a bug whose symptom is the following
firmware stack dump:

iwlwifi 0000:03:00.0: loaded firmware version 17.352738.0 op_mode iwlmvm
iwlwifi 0000:03:00.0: Microcode SW error detected.  Restarting 0x2000000.
iwlwifi 0000:03:00.0: FW error in SYNC CMD TIME_EVENT_CMD
WARNING: CPU: 0 PID: 31459 at
drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1377 iwl_mvm_rx_tx_cmd+0x662/0x870 [iwlmvm]
WARNING: CPU: 0 PID: 28749 at
drivers/net/wireless/intel/iwlwifi/mvm/utils.c:679 iwl_mvm_enable_txq+0x228/0x2a0 [iwlmvm]

Revision number: 459231
Build number: WFFW38520_L14LIN_FW459231

BUG=chromium:705194
TEST=AVL

Change-Id: Ifd112fafb5d6be7239ff36c821b626657b7adcf8
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/459098
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/692acdad625db46232ae704651befa9d9e2e536f/iwlwifi-7260-17.ucode

Kirtika, sorry for the confusion, but that bugzilla I pointed to was reporting two different things and the firmware change I just pushed fixes the other one (i.e. not the tx.c:1377 warning).  The tx.c:1377 warning was already fixed with this commit:

commit 7acaf1cffebca03e92291496561716f2d6b835c6
Author:     Oren Givon <oren.givon@intel.com>
AuthorDate: Sun May 29 14:05:50 2016 +0300
Commit:     Intel ChromeOS bot <linuxwifi@intel.com>
CommitDate: Thu Jun 2 15:15:43 2016 +0300

    CHROMIUM: iwl7000: mvm: fix txq aggregation bug


The bug the new firmware fixes is the 0x14FC, whose symptom is this:

iwlwifi 0000:03:00.0: Start IWL Error Log Dump:
iwlwifi 0000:03:00.0: Status: 0x00000000, count: 6
iwlwifi 0000:03:00.0: Loaded firmware version: 17.352738.0
iwlwifi 0000:03:00.0: 0x000019C2 | ADVANCED_SYSASSERT

I see you already merged the patch, so it doesn't matter, but I just wanted to clarify it.

Comment 4 by kirtika@google.com, Mar 26 2017

Oops, sorry for the confusion. I got excited because of the "FW error in SYNC CMD TIME_EVENT_CMD" which I saw recently in the field (though what I saw was for StP2 not WkP2). I'll open a partner bug for that discussion. 
I'll also revert the commit to add the proper message. This bug was to track testing and M58 branch cherry-pick. 


Project Member

Comment 5 by sheriffbot@chromium.org, Mar 26 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 29 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, May 15 2017

Labels: -Merge-Approved-58
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by yoshi@chromium.org, Jan 3 2018

Cc: -yoshi@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment