New issue
Advanced search Search tips

Issue 705191 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Links involving UTF-8 characters are abruptly cut off in DevTools

Reported by danielaw...@gmail.com, Mar 25 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36

Steps to reproduce the problem:
1. Open the developer tools console
2. Run the following JavaScript:
console.log("http://www.example.com/düsseldorf?neighbourhood=Lörick")

What is the expected behavior?
The entire UTF-8 URL should be recognized as a clickable link

What went wrong?
The link was underlined and clickable until the first U with umlaut in düsseldorf, instead of the entire URL being recognized 

Did this work before? N/A 

Chrome version: 57.0.2987.110  Channel: stable
OS Version: 10.0
Flash Version:
 
chrome_devtools.PNG
7.3 KB View Download
Labels: Needs-Triage-M57
Labels: -Needs-Triage-M57 M-59 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Win 10,Ubuntu 14.04 and Mac 10.12.3 using stable 57.0.2987.110 and canary 59.0.3054.0.
This is a non-regression issue since 35.0.1916.0.

Note: IE and FireFox works fine.
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by l...@chromium.org, Apr 7 2017

Thanks for the report.  It looks like we just need to update our linkifier regex to include characters in url-acceptable unicode ranges.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebb9256e2d0b3971b134aef8d61eefd3eec38621

commit ebb9256e2d0b3971b134aef8d61eefd3eec38621
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jan 06 03:01:07 2018

DevTools: relax console linkifier to allow unicode letters

This CL updates Console's URL-finding regex to be more inclusive of
unicode letters.

Note that Console's regex handles more constraints than
Common.ParsedURL's regex. Since links can be embedded in natural
language, wrapped parentheses are not linkified, for example:
`(www.example.com)`

Bug:  705191 
Change-Id: I01af8e2d37fd09790fbadf739eb33e09f4b1fc1d
Reviewed-on: https://chromium-review.googlesource.com/830663
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527490}
[modify] https://crrev.com/ebb9256e2d0b3971b134aef8d61eefd3eec38621/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links-expected.txt
[modify] https://crrev.com/ebb9256e2d0b3971b134aef8d61eefd3eec38621/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-links.js
[modify] https://crrev.com/ebb9256e2d0b3971b134aef8d61eefd3eec38621/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Comment 6 by l...@chromium.org, Jan 6 2018

Labels: -M-59 M-65
Status: Fixed (was: Assigned)

Sign in to add a comment