New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705188 link

Starred by 1 user
Status: Archived
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ dshi@chromium.org
akes...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Mysql_stats script still dies when mysql goes down

Project Member Reported by pho...@chromium.org, Mar 25 2017 
The upstart job retries the script very quickly. Because the mysql server can be down for more than a minute, the script dies over and over until the upstart job gives up retrying it. We need to add a retry loop inside of mysql_stats.py to prevent it from giving up when mysql goes down.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e86ccd8c5bccf09a9f28fc713786dd499d0eca3d

commit e86ccd8c5bccf09a9f28fc713786dd499d0eca3d
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 07 23:07:02 2017

[mysql_stats] Add retry to mysql_stats queries

Currently the mysql_stats.py script fails very quickly, and even with an
upstart job to retry running it, it will give up quickly. This change
introduces a retry loop (using common_lib.cros.retry).

BUG= chromium:705188 
TEST=retry_unittest.py and mysql_stats_unittest.py pass.

Change-Id: I3e78a34f0f89cf9e134049f0b55bb7d9ab2ed2e3
Reviewed-on: https://chromium-review.googlesource.com/459718
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/e86ccd8c5bccf09a9f28fc713786dd499d0eca3d/site_utils/stats/mysql_stats_unittest.py
[modify] https://crrev.com/e86ccd8c5bccf09a9f28fc713786dd499d0eca3d/site_utils/stats/mysql_stats.py
[modify] https://crrev.com/e86ccd8c5bccf09a9f28fc713786dd499d0eca3d/client/common_lib/cros/retry.py

Comment 2 by pho...@chromium.org, Aug 28 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment