tab discarder doesn't seem to work |
|||||||||||
Issue description
Chrome Version : 58.0.3029.31
OS Version: 9334.18.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
Fill up memory by opening several tabs (e.g. from cnn.com); start inbox; start calendar
You can also use https://semenzato.users.x20web.corp.google.com/www/bloat-auto.html to fill up some memory.
Go to crosh and see if swap is getting full using top.
go to chrome://discards and click on "Discard tab now".
What is the expected result?
Expect a tab to be discarded and available memory to go up.
What happens instead of that?
Nothing is discarded.
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9334.18.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.31 Safari/537.36
,
Mar 26 2017
Tab discarding works if I disable chrome://flags/#enable-memory-coordinator See this issue: 689363
,
Mar 26 2017
,
Mar 26 2017
Hey Chris/ Gabriel, Could you help triage this issue?
,
Mar 26 2017
Thanks willg76x; I can confirm with my repro steps that what you say is true.
,
Mar 26 2017
BTW while I do see memory getting reclaimed shouldn't I see some stats in chrome://discards? I don't see any reports of discarded tabs there. Is this expected?
,
Mar 27 2017
,
Mar 27 2017
,
Mar 27 2017
,
Mar 28 2017
I recently enabled tab discarding with memory coordinator (https://codereview.chromium.org/2735993002) but M58 doesn't include it. Is this still happening on ToT? I couldn't reproduce the issue on my device. FYI: memory coordinator is disabled by default but I'm running a field trial which enables memory coordinator on Canary/Dev. Today I decreased the percentage of the enabled group. Hope it mitigate the pain. Sorry for the trouble.
,
Apr 11 2017
Let me de-prioritize this. Justification: - memory coordinator is disabled by default - On ToT tab discarding should be working with memory coordinator
,
Apr 11 2017
So tab discarding works both with and without the memory coordinator now? If so, what remains to be done here?
,
Apr 11 2017
We're still seeing some reports on canary where discards aren't happening: https://feedback.corp.google.com/product/208/neutron?lView=rd&lRSort=1&lROrder=2&lRFilter=1&lReport=57282709650 bashi@ -- do you see anything interesting in that log?
,
Apr 12 2017
Re: #12 Yes. Tab discarding is enabled with MC has different policies to trigger when to discard tabs. We haven't stabilized policies yet. Re: #13 I can't see the log. How can I request access?
,
Apr 26 2017
sorry for the delay, re #14 -- try reloading the page, sometimes it says denied for me too, but i reload the report and then it works. We're also adding more logging in tab_manager_delegate_chromeos.cc to log these cases where sometimes a tab isn't discarded
,
Feb 23 2018
,
Feb 23 2018
I don't know what category tab discarding is internally, but it's not browser UI. Maybe the Blink Memory folks know.
,
Feb 23 2018
,
Feb 23 2018
Francois, what component should tab manager bugs have?
,
Mar 8 2018
Hmm... I don't think we have a good component to use yet. We've been using Hotlist-TooManyTabs in the meantime. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by puneetster@chromium.org
, Mar 25 2017