New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705175 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Mar 2017
Cc:
█ ben@chromium.org
█ roc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cloud Print Connector cannot register printers

Project Member Reported by thestig@chromium.org, Mar 25 2017 
Chrome Version: 59.0.3049.0
OS: Windows

What steps will reproduce the problem?
(0) Need Chrome branded official builds and a Windows machine where the firewall doesn't get in the way
(1) Visit chrome://devices, click "Add Printers"
(2) Sign in if needed
(3) Select a sign printer to add, continue
(4) When printer registration finishes, click the "manage your printers" link which takes you to https://www.google.com/cloudprint/#printers

What is the expected result?

The newly added printer shows up

What happens instead?

The newly added printer does not show up


I bisected to r458954, but I have no idea what's wrong. Can you help take a look at the mojo code in chrome/service and if it's failing?

Comment 1 by roc...@chromium.org, Mar 25 2017

Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
I think I already know what this is, and it also explains the error log spam I'm seeing in my console on ToT. I'll upload a fix.

Comment 2 by thestig@chromium.org, Mar 25 2017 

Ohhh, nice. I have a test laptop setup to reproduce this. I'll be happy to test your fix.

Comment 3 by roc...@chromium.org, Mar 25 2017 

False positive. The bug I found is unrelated and ultimately innocuous. I'll
keep digging.

Comment 4 by thestig@chromium.org, Mar 25 2017 

I see ServiceIPCServer::OnChannelConnected() getting called, and soon after, ServiceIPCServer::OnChannelError().

Comment 5 by roc...@chromium.org, Mar 25 2017 

I am currently stumped. How certain are you of the bisect? Does it reliably get fixed if you revert that CL, and reappear if you reland it?

Comment 6 by roc...@chromium.org, Mar 25 2017 

I didn't think the utility process connected to ServiceIPCServer, but my only reasonable guess right now is that a utility process is crashing. Possibly because of bug 704747?

Comment 7 by roc...@chromium.org, Mar 25 2017 

I think I got it. Can you try this? https://codereview.chromium.org/2779443002

Comment 8 by thestig@chromium.org, Mar 25 2017 

I'm trying r458953 to double check. It takes a bit to link for official builds, so I'll try your patch as soon as I can.

Comment 9 by thestig@chromium.org, Mar 25 2017 

r458953 works, and I do see a bunch of crashes logged in chrome://crashes on the test machine. Going to try a variation of your CL soon.

Comment 10 by thestig@chromium.org, Mar 25 2017

Status: Started (was: Assigned)
Since your CL fixes my problem, this bug is just a repro case for bug 704747.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7844edf8040581364b3651ac6e0f4ddbc27efe9a

commit 7844edf8040581364b3651ac6e0f4ddbc27efe9a
Author: rockot <rockot@chromium.org>
Date: Sat Mar 25 03:04:21 2017

Fix nullptr deref in ChildThreadImpl

It's possible that a child process has no Service Manager connection. This
avoids dereferencing a null |service_manager_connection_| in that case.

BUG= 705175 ,704747
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2779443002
Cr-Commit-Position: refs/heads/master@{#459634}

[modify] https://crrev.com/7844edf8040581364b3651ac6e0f4ddbc27efe9a/content/child/child_thread_impl.cc

Comment 12 by roc...@chromium.org, Mar 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment