DataReductionProxy.ConfigService.HTTPRequests is not recorded precisely |
|||
Issue descriptionDataReductionProxy.ConfigService.HTTPRequests records whether the data reduction proxy (DRP) config was available at the time the HTTP request was made. However, currently DataReductionProxy.ConfigService.HTTPRequests is not recorded precisely. It should not be recorded when: (1) Chrome is in data reduction proxy holdback experiment. (2) URL is a local host URL. Further, currently a false sample is recorded when DRP was not used even if the config service had already provided the proxy config. Instead, in those cases, a true sample should be recorded.
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13390fea415c0b7ac32a5c8de7e370ba57a15440 commit 13390fea415c0b7ac32a5c8de7e370ba57a15440 Author: tbansal <tbansal@chromium.org> Date: Tue Mar 28 21:10:00 2017 Fix recording of DataReductionProxy.ConfigService.HTTPRequests Do not record if: (1) Chrome is in data reduction proxy holdback experiment. (2) URL is a local host URL. Also, record the sample as false only when the config is missing. BUG= 705167 Review-Url: https://codereview.chromium.org/2776583002 Cr-Commit-Position: refs/heads/master@{#460217} [modify] https://crrev.com/13390fea415c0b7ac32a5c8de7e370ba57a15440/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc [modify] https://crrev.com/13390fea415c0b7ac32a5c8de7e370ba57a15440/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc [modify] https://crrev.com/13390fea415c0b7ac32a5c8de7e370ba57a15440/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h [modify] https://crrev.com/13390fea415c0b7ac32a5c8de7e370ba57a15440/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
,
Mar 28 2017
,
Mar 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted