Computed style generator and Blink rename tool don't agree on how to name things |
||
Issue descriptiongen/blink/core/StyleBuilderFunctions.cpp:1262:58: error: no member named 'TransformOrigin' in 'blink::ComputedStyle'; did you mean 'GetTransformOrigin'? gen/blink/core/StyleBuilderFunctions.cpp:2922:52: error: no member named 'GetTextAlign' in 'blink::ComputedStyle'; did you mean 'TextAlign'? Not sure if there are others, but we should try to make sure they agree on how to name things.
,
Mar 27 2017
Changing the json5 file the intuitive way didn't produce the results expected. Additionally, the generator produces m_fooBar named member variables, which we also need to update.
,
Mar 28 2017
RE: #c2 Do changes to third_party/WebKit/Source/build/scripts/make_computed_style_base.py from https://codereview.chromium.org/2329463004/patch/590001/600039 still apply cleanly? There was one place that needed to be tweaked to pick-up the getter override from json5: - getter_method_name = property_name_lower + getter_method_name = property_['getter'] (AFAIR property_['getter'] would contain the right thing in absence of an explicit getter override in json5). BTW: If the one-line change above helps, then we can probably pre-land it.
,
Mar 28 2017
I think this area of the code got refactored in the meantime, but I haven't had a chance to see if we can do something there to fix it. https://codereview.chromium.org/2762573005
,
Jul 21 2017
We worked around this enough to make things work :) |
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Mar 24 2017