New issue
Advanced search Search tips

Issue 705115 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Offline Pages] Improve UMA granularity for pruned entries

Project Member Reported by petewil@chromium.org, Mar 24 2017

Issue description

In CleanupTask::Prune(), we could pass back the reason that we removed the request.  However, it needs to travel through a series of callbacks including through the request queue.
 

Comment 1 by dim...@chromium.org, Mar 29 2017

Labels: OS-Android
Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)
Owner: fgor...@chromium.org
Status: Started (was: Assigned)
This task will additionally take care of attempts during which Chrome was killed (by OS, crashed or swiped away by the user).
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb86cbdb812080c795bef2b2b21089d30c1797fc

commit cb86cbdb812080c795bef2b2b21089d30c1797fc
Author: fgorski <fgorski@chromium.org>
Date: Tue May 16 22:45:09 2017

[Offline pages] Reporting completed attempt when Chrome is killed

* Adds new Offliner::RequestStatus::BROWSER_KILLED.
* Reports UMA for requests updated in reconcile task with the status
  above.

BUG= 705115 
R=petewil@chromium.org

Review-Url: https://codereview.chromium.org/2883413002
Cr-Commit-Position: refs/heads/master@{#472233}

[modify] https://crrev.com/cb86cbdb812080c795bef2b2b21089d30c1797fc/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/cb86cbdb812080c795bef2b2b21089d30c1797fc/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/cb86cbdb812080c795bef2b2b21089d30c1797fc/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment