New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705109 link

Starred by 1 user
Status: Assigned
Owner:
█ ckrasic@chromium.org
Last visit > 30 days ago
Cc:
rch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Make sure request with body matching PUSH_PROMISE case is handled properly

Project Member Reported by ckrasic@chromium.org, Mar 24 2017 
Per offline discussion, it looks like the logic in QuicHttpStream::SendRequest() doesn't handle the case where the matching request has a body correctly.   The next state should be STATE_REQUEST_STREAM but would actually be STATE_HANDLE_PROMISE.   

Need a test to exercise this.  Probably it will cause a crash.

Comment 1 by rch@chromium.org, Mar 24 2017

Labels: -Pri-2 Pri-1
Marking P1 since it is a potential crasher. If we can verify that it's not a crash, we can lower the priority.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee375739b384173dea843b8f4e1632a4318d4d3

commit dee375739b384173dea843b8f4e1632a4318d4d3
Author: ckrasic <ckrasic@chromium.org>
Date: Thu Apr 06 22:42:27 2017

QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109

Review-Url: https://codereview.chromium.org/2804723003
Cr-Commit-Position: refs/heads/master@{#462659}

[modify] https://crrev.com/dee375739b384173dea843b8f4e1632a4318d4d3/net/quic/chromium/quic_http_stream.cc
[modify] https://crrev.com/dee375739b384173dea843b8f4e1632a4318d4d3/net/quic/chromium/quic_network_transaction_unittest.cc
►

Sign in to add a comment