New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705103 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Offline Pages] Remove references to activation time

Project Member Reported by petewil@chromium.org, Mar 24 2017 
PickRequestTask::RequestConditionsSatisfied()

has some calls that deal with activation time.  This was a concept we originally designed, but never fully implemented.  We ended up not using it because another project will take care of the need it was originally designed for.  Let's remove it.

Comment 1 by dim...@chromium.org, Mar 29 2017

Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by romax@chromium.org, Apr 6 2017

Cc: petewil@chromium.org
Owner: romax@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521

commit 92dd0fe1f2cc4acc05593a8f64a26f55f1f86521
Author: romax <romax@chromium.org>
Date: Sat Apr 08 01:17:15 2017

[Offline Pages] Remove activation time for background loading.

Since activation time is no longer used, remove all codes related.

BUG= 705103 

Review-Url: https://codereview.chromium.org/2804543003
Cr-Commit-Position: refs/heads/master@{#463097}

[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/pick_request_task.cc
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/request_queue_store_sql.h
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/request_queue_store_unittest.cc
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/save_page_request.cc
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/save_page_request.h
[modify] https://crrev.com/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521/components/offline_pages/core/background/save_page_request_unittest.cc

Comment 4 by romax@chromium.org, Apr 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment