New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705090 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 22 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Snapshot on last timeout retry on Background Offliner

Project Member Reported by romax@chromium.org, Mar 24 2017

Issue description

Discuss and decide if we should have a similar functionality for taking a snapshot of whatever we have loaded if it's the last retry per policy and it's a timeout.
Counterpart for prerenderer: 680363
 

Comment 2 by dim...@chromium.org, Mar 29 2017

Labels: -Pri-3 Pri-2
Owner: romax@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by chili@chromium.org, Apr 13 2017

Owner: chili@chromium.org
Status: Started (was: Assigned)
Taking this over because some UMA we should add too. Let me know if you are already working on this.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bcd8469054bf76be2008630904f4e2f9ba146e1

commit 3bcd8469054bf76be2008630904f4e2f9ba146e1
Author: chili <chili@chromium.org>
Date: Tue Apr 18 01:04:36 2017

[Offline pages]: Implement background loader to save on last retry, and record last retry success UMA separately

BUG= 705090 

Review-Url: https://codereview.chromium.org/2818783002
Cr-Commit-Position: refs/heads/master@{#465088}

[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/components/offline_pages/core/background/request_coordinator_event_logger.cc
[modify] https://crrev.com/3bcd8469054bf76be2008630904f4e2f9ba146e1/tools/metrics/histograms/histograms.xml

Comment 5 by chili@chromium.org, Jun 20 2017

Status: Fixed (was: Started)

Sign in to add a comment