Assert in tests that Last N namespace has the appropriate policy |
|||
Issue descriptionWe added some tests that use Last N namespace as a proxy for "only show in original tab". This is fine, but the test should fail if the namespace policy changes. https://cs.chromium.org/chromium/src/components/offline_pages/core/offline_page_model_impl_unittest.cc?rcl=2ad0e26fba82875b90424b386851cfd1abd855a0&l=1036
,
Apr 25 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f71c8b5c87a14a7b487f2897c06867282a8de8 commit 65f71c8b5c87a14a7b487f2897c06867282a8de8 Author: dewittj <dewittj@chromium.org> Date: Thu Apr 27 00:12:03 2017 [Offline Pages] Remove dependencies from particular namespaces in tests. This is not always possible (for tests explicitly testing particular production namespace behavior). But some tests are just around general namespace policy behavior. BUG= 705086 Review-Url: https://codereview.chromium.org/2841223003 Cr-Commit-Position: refs/heads/master@{#467524} [modify] https://crrev.com/65f71c8b5c87a14a7b487f2897c06867282a8de8/components/offline_pages/core/offline_page_model_impl_unittest.cc [modify] https://crrev.com/65f71c8b5c87a14a7b487f2897c06867282a8de8/components/offline_pages/core/offline_page_storage_manager_unittest.cc
,
Apr 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by petewil@chromium.org
, Mar 31 2017