New issue
Advanced search Search tips

Issue 705070 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove update_client::Configurator::StepDelay

Project Member Reported by sorin@chromium.org, Mar 24 2017

Issue description

This configuration parameter was used to slow down the pace of a component update. In time, the code has been refactored and the value of this parameter has been reduced to 1 second. This is unlikely to have any meaningful impact on how component updates are being handled. Therefore, we remove it  for the sake of eliminating the clutter from the code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0437959c3f974fe8c293118b6ab9507688468cbc

commit 0437959c3f974fe8c293118b6ab9507688468cbc
Author: sorin <sorin@chromium.org>
Date: Tue Mar 28 16:43:07 2017

remove update_client::Configurator::StepDelay

BUG= 705070 

Review-Url: https://codereview.chromium.org/2773973003
Cr-Commit-Position: refs/heads/master@{#460127}

[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/component_updater/configurator_impl.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/component_updater/configurator_impl.h
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/component_updater/configurator_impl_unittest.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/update_client/action_update.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/update_client/configurator.h
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/update_client/test_configurator.cc
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/components/update_client/test_configurator.h
[modify] https://crrev.com/0437959c3f974fe8c293118b6ab9507688468cbc/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Comment 2 by sorin@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

Sign in to add a comment