New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Log foreground duration for failed provisional loads.

Project Member Reported by bmcquade@chromium.org, Mar 24 2017

Issue description

We log the foreground duration for both committed and failed provisional loads in UKM. We should do the same in UMA.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db499251a795b754dbef05b1d73a5e877001da8

commit 8db499251a795b754dbef05b1d73a5e877001da8
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Mar 24 22:26:10 2017

Log foreground duration for failed provisional loads.

UKM logs foreground duration for both committed and provisional loads.
This change makes core UMA metrics more consistent with UKM.

This metric will also help to measure the impact of the delayed navigation
experiment, where we expect there to be an increased number of
failed provisional loads.

BUG= 705058 

Review-Url: https://codereview.chromium.org/2771293002
Cr-Commit-Position: refs/heads/master@{#459576}

[modify] https://crrev.com/8db499251a795b754dbef05b1d73a5e877001da8/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/8db499251a795b754dbef05b1d73a5e877001da8/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/8db499251a795b754dbef05b1d73a5e877001da8/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/8db499251a795b754dbef05b1d73a5e877001da8/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 28 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3

commit 07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Mar 29 05:32:10 2017

Log foreground duration for failed provisional loads.

UKM logs foreground duration for both committed and provisional loads.
This change makes core UMA metrics more consistent with UKM.

This metric will also help to measure the impact of the delayed navigation
experiment, where we expect there to be an increased number of
failed provisional loads.

BUG= 705058 
NOTRY=true
NOPRESUBMIT=true
TBR=csharrison

Review-Url: https://codereview.chromium.org/2771293002
Cr-Commit-Position: refs/heads/master@{#459576}
(cherry picked from commit 8db499251a795b754dbef05b1d73a5e877001da8)

Review-Url: https://codereview.chromium.org/2777413003
Cr-Commit-Position: refs/branch-heads/3029@{#470}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/07c2c1ae6884e80abcc5820f5fb74d49ba8d6ce3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment