New issue
Advanced search Search tips

Issue 705054 link

Starred by 2 users
Status: Fixed
Owner:
alph@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature



Sign in to add a comment

[DevTools] Feature Request: Show Screenshots When Scrubbing On "Frames" Section

Reported by kaycebas...@gmail.com, Mar 24 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3050.0 Safari/537.36

Steps to reproduce the problem:
1. Take a recording in the Performance panel with Screenshots enabled.
2. Hover over one of the green boxes in the "Frames" section of the recording. Or, scrub over frames.

What is the expected behavior?
The screenshot related to that frame is shown in the Overview section (the section that lists FPS, CPU, NET) of the Performance panel.

Or, a yellow line shows up on the Overview, providing a cue as to what section of the recording I'm hovering over.

What went wrong?
Feature not implemented.

Did this work before? No 

Chrome version: 59.0.3050.0  Channel: canary
OS Version: OS X 10.12.3
Flash Version: 

When I'm zoomed on a portion of a recording. It's hard to mentally map the Flame Chart, Frames section, etc., to the Overview. Of course there are the timestamps at the top of both sections, but an automatic visual cue would be more helpful.
frames.png
10.8 KB View Download
hover.png
233 KB View Download

Comment 1 by kaycebas...@gmail.com, Mar 24 2017 

Note that the Network panel does have a feature similar to what I'm looking for. When you enable screenshots and reload the page, clicking on a screenshot overlays a yellow bar on the "Overview" section of the Network panel.

Comment 2 by ajha@chromium.org, Mar 27 2017

Labels: Needs-Triage-M59

Comment 3 by ajha@chromium.org, Mar 27 2017

Labels: -Needs-Triage-M59 M-59
Status: Untriaged (was: Unconfirmed)
Marking this as Untriaged as Feature request for more inputs on this from the respective team.

Comment 4 by einbinder@chromium.org, Mar 27 2017

Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by alph@chromium.org, Apr 22 2017

Screenshot from 2017-04-21 18:10:17.png
204 KB View Download

Comment 6 by alph@chromium.org, Apr 22 2017

Labels: -Type-Bug -M-59 M-60 Type-Feature
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda69aa7da5a081bd6014c56cadec2902b35f10e

commit cda69aa7da5a081bd6014c56cadec2902b35f10e
Author: alph <alph@chromium.org>
Date: Fri Apr 28 20:37:53 2017

Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ )

Reason for revert:
Panning does not work, as well as HiDPI.

Original issue's description:
> DevTools: Show screenshots on the main flamechart
>
> The patch puts the screenshots on the frame bar and makes it expandable.
>
> BUG= 705054 
>
> Review-Url: https://codereview.chromium.org/2830343004
> Cr-Commit-Position: refs/heads/master@{#466821}
> Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd

TBR=pfeldman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 705054 

Review-Url: https://codereview.chromium.org/2854473002
Cr-Commit-Position: refs/heads/master@{#468116}

[modify] https://crrev.com/cda69aa7da5a081bd6014c56cadec2902b35f10e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/cda69aa7da5a081bd6014c56cadec2902b35f10e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js
[modify] https://crrev.com/cda69aa7da5a081bd6014c56cadec2902b35f10e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/cda69aa7da5a081bd6014c56cadec2902b35f10e/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35061bcb47bf268077a37ae7a44f334d585745a6

commit 35061bcb47bf268077a37ae7a44f334d585745a6
Author: alph <alph@chromium.org>
Date: Tue May 02 23:37:08 2017

DevTools: Show screenshots on the main flamechart

The patch puts the screenshots on the frame bar and makes it expandable.

BUG= 705054 

Review-Url: https://codereview.chromium.org/2852173002
Cr-Commit-Position: refs/heads/master@{#468819}

[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css
[modify] https://crrev.com/35061bcb47bf268077a37ae7a44f334d585745a6/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 12 by alph@chromium.org, Oct 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment