Whenever I run “git cl upload” or “git cl description” for something that’s already been uploaded once, it litters my checkout with a garbage directory |
|||||||
Issue descriptionWhen I run “git cl upload”, “git cl description”, or other useful “git cl” things, I’m getting this detritus in my checkout: Untracked files: (use "git add <file>..." to include in what will be committed) chromium-review.googlesource.com/ mark@mela zsh% ls -la chromium-review.googlesource.com/ total 40 drwxr-xr-x 3 mark staff 102 Mar 24 15:35 . drwxr-xr-x 28 mark staff 952 Mar 24 15:35 .. -rw-r--r-- 1 mark staff 17114 Mar 24 15:35 chromium-review.googlesource.com,a,changes,459039,detail,o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT,7b30525ebdbbd005648990ecd2152d4b and that file has what looks like an entire HTTP response (some header fields snipped): status: 200 content-length: 15480 response_code_set_by_backend yvs77:4652, /bns/yv/borg/yv/bns/gerritcodereview/gfe/2, qka65:443 cache-control: private, max-age=0, must-revalidate alt-svc: quic=":443"; ma=2592000; v="37,36,35" content-disposition: attachment expires: Fri, 24 Mar 2017 19:35:39 GMT -content-encoding: gzip date: Fri, 24 Mar 2017 19:35:39 GMT content-location: https://chromium-review.googlesource.com/a/changes/459039/detail?o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT /bns/yv/borg/yv/bns/gerritcodereview/prd.gerrit.frontend/4, yvs77:4652, qka65:443 strict-transport-security: max-age=31536000; includeSubDomains; preload main:gerritcodereview-gfe server: GSE content-type: application/json; charset=UTF-8 )]}' { "id": "crashpad%2Fcrashpad~master~I73bd2be1437d05f0501a146dcb9efbe3b8e0f8b7", "project": "crashpad/crashpad", "branch": "master", "hashtags": [], "change_id": "I73bd2be1437d05f0501a146dcb9efbe3b8e0f8b7", "subject": "win: Be more careful about child process exit codes", "status": "NEW", "created": "2017-03-24 19:02:45.000000000", "updated": "2017-03-24 19:31:32.000000000", "submit_type": "CHERRY_PICK", "mergeable": false, "insertions": 76, "deletions": 51, "unresolved_comment_count": 0, "_number": 459039, "owner": { […blah blah blah…]
,
Mar 24 2017
OK, I’m not crazy, it’s “git cl upload” too, but only for subsequent patch sets. The initial “git cl upload” doesn’t seem to do this. I’m working with Gerrit, by the way. And I only started noticing this today or last night.
,
Mar 24 2017
Yeah, "git cl comments" does it too. Haven't noticed this before, must be very recent.
,
Mar 24 2017
,
Mar 24 2017
Culprit is https://chromium.googlesource.com/chromium/tools/depot_tools/+/89d04858c88d91acf491e259d293ba3206713357 Unassigning from tandrii because not actually related to his relevant git-cl-comments and git-cl-description work.
,
Mar 24 2017
It's because httplib2 by default uses a filesystem cache if it isn't given an in-memory one instead. Working on a CL to use an in-memory cache instead.
,
Mar 24 2017
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d2db5a2240eaa5e661884314911689b0d022d5d9 commit d2db5a2240eaa5e661884314911689b0d022d5d9 Author: Aaron Gable <agable@chromium.org> Date: Mon Mar 27 17:10:56 2017 gerrit_util: stop accidentally using hostname as cache path httplib2 uses an on-disk cache whose path is given by the first argument to the httplib2.Http constructor. The `(host)` parameter was left over from some earlier edition of this code that didn't do on-disk caching. Bug: 705046 Change-Id: I061324e4d1bbd680502230aefc73fe66daccaba1 Reviewed-on: https://chromium-review.googlesource.com/458967 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/d2db5a2240eaa5e661884314911689b0d022d5d9/gerrit_util.py
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d2db5a2240eaa5e661884314911689b0d022d5d9 commit d2db5a2240eaa5e661884314911689b0d022d5d9 Author: Aaron Gable <agable@chromium.org> Date: Mon Mar 27 17:10:56 2017 gerrit_util: stop accidentally using hostname as cache path httplib2 uses an on-disk cache whose path is given by the first argument to the httplib2.Http constructor. The `(host)` parameter was left over from some earlier edition of this code that didn't do on-disk caching. Bug: 705046 Change-Id: I061324e4d1bbd680502230aefc73fe66daccaba1 Reviewed-on: https://chromium-review.googlesource.com/458967 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/d2db5a2240eaa5e661884314911689b0d022d5d9/gerrit_util.py
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d2db5a2240eaa5e661884314911689b0d022d5d9 commit d2db5a2240eaa5e661884314911689b0d022d5d9 Author: Aaron Gable <agable@chromium.org> Date: Mon Mar 27 17:10:56 2017 gerrit_util: stop accidentally using hostname as cache path httplib2 uses an on-disk cache whose path is given by the first argument to the httplib2.Http constructor. The `(host)` parameter was left over from some earlier edition of this code that didn't do on-disk caching. Bug: 705046 Change-Id: I061324e4d1bbd680502230aefc73fe66daccaba1 Reviewed-on: https://chromium-review.googlesource.com/458967 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/d2db5a2240eaa5e661884314911689b0d022d5d9/gerrit_util.py
,
Mar 27 2017
Fixed. And the bugdroid triple comments are https://bugs.chromium.org/p/chromium/issues/detail?id=699987
,
Mar 27 2017
Issue 705018 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mark@chromium.org
, Mar 24 2017