New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 705033 link

Starred by 2 users
Status: Started
Owner:
rch@chromium.org
Cc:
rch@chromium.org
b...@chromium.org
█ ianswett@chromium.org
█ susanjuniab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 705027



Sign in to add a comment

Mark QUIC broken when connections timeout with open streams or with too many RTOs

Project Member Reported by rch@chromium.org, Mar 24 2017 
Currently, QUIC is only marked as broken when the QUIC handshake fails. However, this does not catch situations where the connection becomes a blackhole after the handshake. We have seen this behavior in the wild several times.

To handle this, we should also mark QUIC as broken if a connection times out with open streams or if it suffers too many RTOs.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab11cdbc638822aac069e23db9417d028e076a2

commit fab11cdbc638822aac069e23db9417d028e076a2
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Apr 13 15:07:24 2017

Revert of When HttpNetworkTransaction encounters QUIC errors, retry the request (patchset #3 id:40001 of https://codereview.chromium.org/2818623002/ )

Reason for revert:
Likely cause of compilation error in Win x64.

BUG= 711316 

Original issue's description:
> When HttpNetworkTransaction encounters QUIC errors, retry the request
> with alt-svc disabled, and if that succeeds then mark QUIC as broken.
>
> Protected by the retry_without_alt_svc_on_quic_errors finch param.
>
> BUG=705033
>
> Review-Url: https://codereview.chromium.org/2818623002
> Cr-Commit-Position: refs/heads/master@{#464391}
> Committed: https://chromium.googlesource.com/chromium/src/+/d0dbccf1f8d23dfa32defdd02c0a3df990729358

TBR=jri@chromium.org,ianswett@chromium.org,rch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705033

Review-Url: https://codereview.chromium.org/2811993005
Cr-Commit-Position: refs/heads/master@{#464403}

[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/components/network_session_configurator/network_session_configurator_unittest.cc
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/net/http/http_network_session.cc
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/net/http/http_network_session.h
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/net/http/http_network_transaction.cc
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/net/http/http_network_transaction.h
[modify] https://crrev.com/fab11cdbc638822aac069e23db9417d028e076a2/net/quic/chromium/quic_network_transaction_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f2991ce896d93583dc3dab2ba6466fcae3d23b3

commit 2f2991ce896d93583dc3dab2ba6466fcae3d23b3
Author: rch <rch@chromium.org>
Date: Thu Apr 13 19:28:17 2017

When HttpNetworkTransaction encounters QUIC errors, retry the request
with alt-svc disabled, and if that succeeds then mark QUIC as broken.

Protected by the retry_without_alt_svc_on_quic_errors finch param.

BUG=705033

Review-Url: https://codereview.chromium.org/2818623002
Cr-Original-Commit-Position: refs/heads/master@{#464391}
Committed: https://chromium.googlesource.com/chromium/src/+/d0dbccf1f8d23dfa32defdd02c0a3df990729358
Review-Url: https://codereview.chromium.org/2818623002
Cr-Commit-Position: refs/heads/master@{#464502}

[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/components/network_session_configurator/network_session_configurator_unittest.cc
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/net/http/http_network_session.cc
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/net/http/http_network_session.h
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/net/http/http_network_transaction.cc
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/net/http/http_network_transaction.h
[modify] https://crrev.com/2f2991ce896d93583dc3dab2ba6466fcae3d23b3/net/quic/chromium/quic_network_transaction_unittest.cc

Comment 4 by b...@chromium.org, Oct 10 2017

Status: Started (was: Untriaged)

Comment 5 by b...@chromium.org, Oct 10 2017

Cc: b...@chromium.org rch@chromium.org susanjuniab@chromium.org
 Issue 709912  has been merged into this issue.
►

Sign in to add a comment