New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705031 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 705027



Sign in to add a comment

Mark QUIC broken when QUIC_PROTOCOL_ERROR is returned

Project Member Reported by rch@chromium.org, Mar 24 2017

Issue description

When there is a problem with QUIC that leads to QUIC_PROTOCOL_ERROR, Chrome should mark QUIC as broken and retry the request over TCP.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ecde09b169332d9ebd04dba35fb4bd41b129840

commit 9ecde09b169332d9ebd04dba35fb4bd41b129840
Author: rch <rch@chromium.org>
Date: Sat Apr 08 00:18:23 2017

Mark QUIC broken when the network blackholes after the handshake,
and retry such requests in HttpNetworkTransaction.

Only when enable via the mark_quic_broken_when_network_blackholed finch
param is enabled.

BUG=705031

Review-Url: https://codereview.chromium.org/2789093003
Cr-Commit-Position: refs/heads/master@{#463067}

[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/components/network_session_configurator/network_session_configurator_unittest.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/base/net_error_list.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/http/http_network_session.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/http/http_network_session.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/http/http_network_transaction.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/http/http_server_properties.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_http_stream.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_http_stream.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_stream_factory_peer.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_stream_factory_peer.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_test_packet_maker.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/quic_test_packet_maker.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/test_task_runner.cc
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/net/quic/chromium/test_task_runner.h
[modify] https://crrev.com/9ecde09b169332d9ebd04dba35fb4bd41b129840/tools/metrics/histograms/histograms.xml

Sign in to add a comment