Persist QUIC broken state |
||||||
Issue descriptionCurrently broken alternate servers are not persisted to disk. This means that when Chrome restarts it will not know that those servers support the alternate service. This is fine. However, it also means that the broken backoff timer is reset for those servers. In the case of Android, this may well be quite problematic. We should persist recently_broken_alternative_services_ from HttpServerPropertiesImpl.
,
Mar 25 2017
zhongyi: As discussed on Friday this is requires some work in HttpServerProperties, which you're already familiar with after your work with using "origins" and "servers".
,
Mar 26 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8 commit c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8 Author: zhongyi <zhongyi@chromium.org> Date: Fri Apr 07 05:09:49 2017 Persist QUIC Broken State 0: change RecentlyBrokenAlternativeServies to base::MRUCache instead of std::map. No functional change. BUG= 705029 Review-Url: https://codereview.chromium.org/2801533002 Cr-Commit-Position: refs/heads/master@{#462760} [modify] https://crrev.com/c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8/net/http/http_server_properties.h [modify] https://crrev.com/c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8/net/http/http_server_properties_impl.cc [modify] https://crrev.com/c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8/net/http/http_server_properties_impl.h [modify] https://crrev.com/c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8/net/http/http_server_properties_impl_unittest.cc
,
Apr 24 2017
,
Apr 24 2017
wangyix: can you take this on? zhongyi is very familiar with the code and can act as a reviewer.
,
Apr 25 2017
@rch: yes, I will get on this.
,
Apr 25 2017
wangyix: thanks for taking care of this. Feel free to let me know if you need any help.
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a66ebc8af26cdad325746d9d5644169a16996821 commit a66ebc8af26cdad325746d9d5644169a16996821 Author: Yixin Wang <wangyix@chromium.org> Date: Thu Jul 13 23:09:01 2017 Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG= 705029 Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 Reviewed-on: https://chromium-review.googlesource.com/562604 Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#486519} [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/broken_alternative_services.cc [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/broken_alternative_services.h [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties.h [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties_impl.cc [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties_impl.h [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties_manager.cc [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties_manager.h [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/a66ebc8af26cdad325746d9d5644169a16996821/tools/metrics/histograms/histograms.xml
,
Jul 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8326494084c29efaae6e6859420eb01d9b339c2a commit 8326494084c29efaae6e6859420eb01d9b339c2a Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Jul 13 23:25:24 2017 Revert "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" This reverts commit a66ebc8af26cdad325746d9d5644169a16996821. Reason for revert: Appears to have caused compile failure on Linux x64: https://luci-milo.appspot.com/buildbot/chromium/Linux%20x64/44132 Original change's description: > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > BUG= 705029 > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > Reviewed-on: https://chromium-review.googlesource.com/562604 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486519} TBR=rch@chromium.org,holte@chromium.org,zhongyi@chromium.org,wangyix@chromium.org Change-Id: I946b3205a67356c0130ef53efbba245a1768d601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 705029 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/571259 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486525} [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/broken_alternative_services.cc [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/broken_alternative_services.h [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties.h [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties_impl.cc [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties_impl.h [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties_manager.cc [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties_manager.h [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/8326494084c29efaae6e6859420eb01d9b339c2a/tools/metrics/histograms/histograms.xml
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c0837065ee0522dc05b2908a6815c25146ad1b2 commit 9c0837065ee0522dc05b2908a6815c25146ad1b2 Author: Yixin Wang <wangyix@chromium.org> Date: Tue Jul 18 02:04:59 2017 Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" This is a reland of a66ebc8af26cdad325746d9d5644169a16996821 Original change's description: > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > BUG= 705029 > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > Reviewed-on: https://chromium-review.googlesource.com/562604 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486519} Bug: 705029 Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/571044 Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#487342} [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/broken_alternative_services.cc [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/broken_alternative_services.h [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties.h [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties_impl.cc [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties_impl.h [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties_manager.cc [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties_manager.h [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/9c0837065ee0522dc05b2908a6815c25146ad1b2/tools/metrics/histograms/histograms.xml
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b3826e9e73ef081e02004f8f558d672b476438c commit 5b3826e9e73ef081e02004f8f558d672b476438c Author: Alice Boxhall <aboxhall@chromium.org> Date: Tue Jul 18 03:29:49 2017 Revert "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"" This reverts commit 9c0837065ee0522dc05b2908a6815c25146ad1b2. Reason for revert: This seems to have broken tests, sorry: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/41713 Original change's description: > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" > > This is a reland of a66ebc8af26cdad325746d9d5644169a16996821 > Original change's description: > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > BUG= 705029 > > > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > > Reviewed-on: https://chromium-review.googlesource.com/562604 > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#486519} > > Bug: 705029 > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/571044 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487342} TBR=holte@chromium.org,zhongyi@chromium.org,wangyix@chromium.org Change-Id: Ieee4be83dbc33044c1b36361aa9541240c32b95b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 705029 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/575311 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487373} [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/broken_alternative_services.cc [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/broken_alternative_services.h [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties.h [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties_impl.cc [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties_impl.h [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties_manager.cc [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties_manager.h [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/5b3826e9e73ef081e02004f8f558d672b476438c/tools/metrics/histograms/histograms.xml
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/724ac890c910d8633ef1428f0f38a222a6d4eb2a commit 724ac890c910d8633ef1428f0f38a222a6d4eb2a Author: Yixin Wang <wangyix@chromium.org> Date: Wed Jul 19 21:24:59 2017 Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"" This is a reland of 9c0837065ee0522dc05b2908a6815c25146ad1b2 Original change's description: > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" > > This is a reland of a66ebc8af26cdad325746d9d5644169a16996821 > Original change's description: > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > BUG= 705029 > > > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > > Reviewed-on: https://chromium-review.googlesource.com/562604 > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#486519} > > Bug: 705029 > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/571044 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487342} Bug: 705029 Change-Id: Iefb798a8c4d54263e5e8f47bc5d1c63c04d72f77 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/576349 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#487990} [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/broken_alternative_services.cc [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/broken_alternative_services.h [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties.h [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties_impl.cc [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties_impl.h [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties_manager.cc [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties_manager.h [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/724ac890c910d8633ef1428f0f38a222a6d4eb2a/tools/metrics/histograms/histograms.xml
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756d947a35e25732ad9c58f47683dafbddfe32fd commit 756d947a35e25732ad9c58f47683dafbddfe32fd Author: Ojan Vafai <ojan@chromium.org> Date: Fri Jul 21 18:56:41 2017 Revert "Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager""" This reverts commit 724ac890c910d8633ef1428f0f38a222a6d4eb2a. Reason for revert: Still flakes net_unittests on some bots. BUG= 747424 , 705029 Original change's description: > Reland "Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager"" > > This is a reland of 9c0837065ee0522dc05b2908a6815c25146ad1b2 > Original change's description: > > Reland "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" > > > > This is a reland of a66ebc8af26cdad325746d9d5644169a16996821 > > Original change's description: > > > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > > > > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > > > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > > > > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > > > > > BUG= 705029 > > > > > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > > > Reviewed-on: https://chromium-review.googlesource.com/562604 > > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > > Reviewed-by: Steven Holte <holte@chromium.org> > > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#486519} > > > > Bug: 705029 > > Change-Id: I14f36cc6014f001d9aefa4678a7bfa8f621b2834 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > Reviewed-on: https://chromium-review.googlesource.com/571044 > > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Commit-Queue: Yixin Wang <wangyix@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#487342} > > Bug: 705029 > Change-Id: Iefb798a8c4d54263e5e8f47bc5d1c63c04d72f77 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/576349 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487990} TBR=mpearson@chromium.org,rch@chromium.org,zhongyi@chromium.org,wangyix@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 705029 Change-Id: Icadb2cc56c2e83f2dfdf5dfb327c5d0544bad3d3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/581627 Reviewed-by: Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488724} [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/broken_alternative_services.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/broken_alternative_services.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_impl.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_impl.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager.h [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/756d947a35e25732ad9c58f47683dafbddfe32fd/tools/metrics/histograms/histograms.xml
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3 commit 1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3 Author: Yixin Wang <wangyix@chromium.org> Date: Thu Jul 27 22:48:18 2017 Reland (3rd time) "Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager" Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. Original land: https://chromium-review.googlesource.com/c/562604/ 1st reland: https://chromium-review.googlesource.com/c/571044/ 2nd reland: https://chromium-review.googlesource.com/c/576349/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG= 705029 TBR=mpearson@chromium.org Change-Id: I26a720b21162253dfc0c3e3b2ec8b40ced1e962d Reviewed-on: https://chromium-review.googlesource.com/585782 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490034} [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/broken_alternative_services.cc [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/broken_alternative_services.h [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/broken_alternative_services_unittest.cc [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties.h [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties_impl.cc [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties_impl.h [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties_manager.cc [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties_manager.h [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/net/http/http_server_properties_manager_unittest.cc [modify] https://crrev.com/1c34cc394c0a2c3ad1f779396119b5ef5ec9eef3/tools/metrics/histograms/histograms.xml
,
Nov 10 2017
wangyix: This is fixed now, right? If so can you make the status Fixed?
,
Nov 10 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rch@chromium.org
, Mar 24 2017