New issue
Advanced search Search tips

Issue 705028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 669373



Sign in to add a comment

Device wallpaper policy should never leak into a user's session

Project Member Reported by x...@chromium.org, Mar 24 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: Chrome OS

Per the decision in the email thread, the device wallpaper policy should not affect user's session under any circumstance. See the expected behavior https://docs.google.com/a/google.com/drawings/d/1eNW1KcJNITFO4pBy884-ZRiMa-TbMUn4AifaSujYL4s/edit?usp=sharing.

Currently the device wallpaper may be used as the user's wallpaper within a user's session if there is no user policy controlled wallpaper and user-defined wallpaper. We should revert this change. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c8e69e14bebb66cba7f31887865d76b24817080

commit 8c8e69e14bebb66cba7f31887865d76b24817080
Author: xdai <xdai@chromium.org>
Date: Wed Mar 29 04:56:11 2017

Chrome OS: revert the device wallpaper change within a user session.

The device policy should never leak to a user's session. In the old CL
https://codereview.chromium.org/2572793003 we use the device policy
controlled wallpaper as the user wallpaper within a user's session if
there is no user wallpaper policy controlled wallpaper and no user-
defined wallpaper. This CL reverted this logic.

Note this CL is not a clean fix since I want to keep it simple to merge
back to M58. I'll do a cleaner fix after it's been merged.

BUG= 705028 

Review-Url: https://codereview.chromium.org/2772973003
Cr-Commit-Position: refs/heads/master@{#460281}

[modify] https://crrev.com/8c8e69e14bebb66cba7f31887865d76b24817080/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/8c8e69e14bebb66cba7f31887865d76b24817080/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/8c8e69e14bebb66cba7f31887865d76b24817080/components/wallpaper/wallpaper_manager_base.h

Comment 2 by x...@chromium.org, Mar 30 2017

Labels: Merge-Request-58
Need this change in 58 since we plan to expose the policy to users in 58.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 30 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a148da1e362e8ac74aebe84a1e5495208bc2b1

commit 11a148da1e362e8ac74aebe84a1e5495208bc2b1
Author: xdai <xdai@chromium.org>
Date: Thu Mar 30 17:10:15 2017

[Merge to M58]Chrome OS: revert the device wallpaper change within a user session.

The device policy should never leak to a user's session. In the old CL
https://codereview.chromium.org/2572793003 we use the device policy
controlled wallpaper as the user wallpaper within a user's session if
there is no user wallpaper policy controlled wallpaper and no user-
defined wallpaper. This CL reverted this logic.

Note this CL is not a clean fix since I want to keep it simple to merge
back to M58. I'll do a cleaner fix after it's been merged.

BUG= 705028 
TBR=alemate@chromium.org

Review-Url: https://codereview.chromium.org/2772973003
Cr-Commit-Position: refs/heads/master@{#460281}
(cherry picked from commit 8c8e69e14bebb66cba7f31887865d76b24817080)

Review-Url: https://codereview.chromium.org/2789643002 .
Cr-Commit-Position: refs/branch-heads/3029@{#492}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/11a148da1e362e8ac74aebe84a1e5495208bc2b1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/11a148da1e362e8ac74aebe84a1e5495208bc2b1/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/11a148da1e362e8ac74aebe84a1e5495208bc2b1/components/wallpaper/wallpaper_manager_base.h

Comment 5 by x...@chromium.org, Mar 30 2017

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a87432a3fc9ddfe077ace2d4e2637b0ba08a41b

commit 6a87432a3fc9ddfe077ace2d4e2637b0ba08a41b
Author: xdai <xdai@chromium.org>
Date: Wed Aug 23 22:51:38 2017

Cros: Remove device wallpaper policy related dead code.

This is a piece of remaining dead code after the changes in
 crbug.com/705028 : Device policy controlled wallpaper should only show up
in the login screen and should not affect user's session. Clean it up.

Bug:  705028 
Change-Id: I08728901f36f7c3a2b768321eea733be49f16fff
Reviewed-on: https://chromium-review.googlesource.com/624184
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496842}
[modify] https://crrev.com/6a87432a3fc9ddfe077ace2d4e2637b0ba08a41b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/6a87432a3fc9ddfe077ace2d4e2637b0ba08a41b/components/wallpaper/wallpaper_manager_base.cc

Sign in to add a comment