Use something like ElementToDismissContextMenu in testRepostFormCancelling |
|||
Issue descriptionThis test has custom code for cancelling form resubmission, but ElementToDismissContextMenu does the same thing.
,
Mar 27 2017
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/091e44cb9fb2820dcf394c0d427820710e4d3fad commit 091e44cb9fb2820dcf394c0d427820710e4d3fad Author: Danyao Wang <danyao@chromium.org> Date: Thu Feb 01 16:26:57 2018 [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. This CL moves form repost detection for WKBasedNavigationManager to in |webView:decidePolicyForNavigationAction|, where WKWebView gives a clear signal about form reposting (WKNavigationTypeFormResubmitted). This allows simplifying reload for WKBasedNavigationManager to directly delegating to [WKWebView reload]. FormsTestCase now pass with WKBasedNavigationManager. Bug: 807428,705020 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 Reviewed-on: https://chromium-review.googlesource.com/894892 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533692} [modify] https://crrev.com/091e44cb9fb2820dcf394c0d427820710e4d3fad/ios/chrome/browser/web/forms_egtest.mm [modify] https://crrev.com/091e44cb9fb2820dcf394c0d427820710e4d3fad/ios/testing/earl_grey/matchers.h [modify] https://crrev.com/091e44cb9fb2820dcf394c0d427820710e4d3fad/ios/testing/earl_grey/matchers.mm [modify] https://crrev.com/091e44cb9fb2820dcf394c0d427820710e4d3fad/ios/web/shell/test/context_menu_egtest.mm [modify] https://crrev.com/091e44cb9fb2820dcf394c0d427820710e4d3fad/ios/web/web_state/ui/crw_web_controller.mm
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38717484e5b93a79cbe18d9e1d8d9390990f011d commit 38717484e5b93a79cbe18d9e1d8d9390990f011d Author: Danyao Wang <danyao@chromium.org> Date: Thu Feb 01 22:09:13 2018 Revert "[Nav Experiment] Fix form repost detection in WKBasedNavigationManager." This reverts commit 091e44cb9fb2820dcf394c0d427820710e4d3fad. Reason for revert: Suspect that this broke the tree: https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-device-x64%2F2513%2F%2B%2Frecipes%2Fsteps%2Fios_web_unittests__iPhone_7_iOS_11.2.1__on_iOS-11.2.1%2F0%2Fstdout Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I1db11102b3df8a8c0a37610e36ca229343367c8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807428, 705020 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898164 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#533824} [modify] https://crrev.com/38717484e5b93a79cbe18d9e1d8d9390990f011d/ios/chrome/browser/web/forms_egtest.mm [modify] https://crrev.com/38717484e5b93a79cbe18d9e1d8d9390990f011d/ios/testing/earl_grey/matchers.h [modify] https://crrev.com/38717484e5b93a79cbe18d9e1d8d9390990f011d/ios/testing/earl_grey/matchers.mm [modify] https://crrev.com/38717484e5b93a79cbe18d9e1d8d9390990f011d/ios/web/shell/test/context_menu_egtest.mm [modify] https://crrev.com/38717484e5b93a79cbe18d9e1d8d9390990f011d/ios/web/web_state/ui/crw_web_controller.mm
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/801862cf21e7217aae758124949a9dd401f07feb commit 801862cf21e7217aae758124949a9dd401f07feb Author: Danyao Wang <danyao@chromium.org> Date: Fri Feb 02 20:12:20 2018 [ios] Use ElementToDismissContextMenu in FormsTestCase. This is a partial reland of 091e44cb9fb2820dcf394c0d427820710e4d3fad. It splits out only the matcher change in EarlGrey tests. The suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692} Bug: 705020 Change-Id: I0c5b5f893bc64eaa61538c7a75a78799ac422993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898263 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534132} [modify] https://crrev.com/801862cf21e7217aae758124949a9dd401f07feb/ios/chrome/browser/web/forms_egtest.mm [modify] https://crrev.com/801862cf21e7217aae758124949a9dd401f07feb/ios/testing/earl_grey/matchers.h [modify] https://crrev.com/801862cf21e7217aae758124949a9dd401f07feb/ios/testing/earl_grey/matchers.mm [modify] https://crrev.com/801862cf21e7217aae758124949a9dd401f07feb/ios/web/shell/test/context_menu_egtest.mm
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1fa00527100f5045c95bcc62bdf74c7183951fa commit c1fa00527100f5045c95bcc62bdf74c7183951fa Author: Danyao Wang <danyao@chromium.org> Date: Fri Feb 02 21:46:54 2018 Reland "[Nav Experiment] Fix form repost detection in WKBasedNavigationManager." This is a reland of 091e44cb9fb2820dcf394c0d427820710e4d3fad. It fixes the regression in WebUITestCase/testChromeURLBackAndForwardAndReloadNavigation. WebUI needs special handling in reload because calling [WKWebView -reload] simply reloads WKWebView.URL (which is an app-specific URL in this case) and results in a provisional load failure. The other suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the original CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692}t Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0bb1c907472ec402931c69f347c9259907c4f28 Reviewed-on: https://chromium-review.googlesource.com/899916 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534163} [modify] https://crrev.com/c1fa00527100f5045c95bcc62bdf74c7183951fa/ios/web/web_state/ui/crw_web_controller.mm
,
Sep 20
|
|||
►
Sign in to add a comment |
|||
Comment 1 by edchin@chromium.org
, Mar 27 2017Status: Assigned (was: Untriaged)