New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705014 link

Starred by 1 user

Issue metadata

Status: Assigned
Merged: issue 601483
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit warns about RecordComputedAction after editing actions.xml

Project Member Reported by lgar...@chromium.org, Mar 24 2017

Issue description

I believe I made some changes to actions.xml unrelated to anything in the presubmit warning I'm getting:

INFO:root:Loading actions.xml...
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/browser/ui/webui/metrics_handler.cc has RecordComputedAction statement on line 46
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java uses UserMetricsAction incorrectly on line 1912:
RecordUserAction.record(recordAction)
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java uses UserMetricsAction incorrectly on line 257:
RecordUserAction.record(key)
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java uses UserMetricsAction incorrectly on line 371:
RecordUserAction.record(key)
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java uses UserMetricsAction incorrectly on line 457:
RecordUserAction.record(isSingleWord ? "ContextualSearch.ManualRefineSingleWord"
                                                     : "ContextualSearch.ManualRefineMultiWord")
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java uses UserMetricsAction incorrectly on line 391:
RecordUserAction.record(METRICS_PREFIX + action)
WARNING:root:/usr/local/google/home/lgarron/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmImportSyncDataDialog.java uses UserMetricsAction incorrectly on line 190:
RecordUserAction.record(mKeepSeparateOption.isChecked()
WARNING:root:/usr/local/google/home/lgarron/chromium/src/content/child/child_thread_impl.cc has RecordComputedAction statement on line 636
INFO:root:actions.xml is correctly pretty-printed.

isherman@, could you triage?
 
Mergedinto: 601483
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
This is a different issue (mostly, we don't run the presubmit unless actions.xml was actually modified, so we'll catch things from previously-submitted CLs, late).

Sign in to add a comment