New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 705006 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 644562



Sign in to add a comment

VR: Parse glTF models

Project Member Reported by acondor@google.com, Mar 24 2017

Issue description

The parser should parse the glTF properties and leave the vertex data in CPU memory.
This parser is for internal usage within Chromium (not user or third-party data).

Discussion in: https://groups.google.com/a/chromium.org/forum/#!topic/graphics-dev/NxG1JunmBO8
 

Comment 1 by acondor@google.com, Mar 24 2017

Blocking: 644562

Comment 2 by acondor@google.com, Mar 24 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76f0b59ca704c56c693b2390a8033f834b08a3f

commit a76f0b59ca704c56c693b2390a8033f834b08a3f
Author: acondor <acondor@google.com>
Date: Fri Mar 24 20:57:19 2017

Implementing glTF 1.0 parser

- Documentation at https://github.com/KhronosGroup/glTF/tree/2.0/specification/1.0
- Elements which we will not be using are excluded, such as materials, textures, shaders, skins. We might want to use them later when glTF 2.0 is released. For now, we plan to handle this natively.
- Unittests are included.
- Small refactoring of the rendering classes inheritance to account for non-quad objects, which will be used later for rendering the controller.
- Minor fixes on code I encountered.

BUG= 705006 

Review-Url: https://codereview.chromium.org/2757213003
Cr-Commit-Position: refs/heads/master@{#459547}

[modify] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/gltf_asset.cc
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/gltf_asset.h
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/gltf_parser.cc
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/gltf_parser.h
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/gltf_parser_unittest.cc
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/test/data/sample_inline.gltf
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/test/paths.cc
[add] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/test/paths.h
[modify] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/vr_math.cc
[modify] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/a76f0b59ca704c56c693b2390a8033f834b08a3f/chrome/browser/android/vr_shell/vr_shell_renderer.h

Comment 4 by acondor@google.com, Mar 24 2017

Description: Show this description

Comment 6 by acondor@google.com, Mar 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment