New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704999 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 22 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add UMA to record loading failed error codes and final per-request status codes

Project Member Reported by chili@chromium.org, Mar 24 2017

Issue description

In order to get better understanding of our higher LOADING_FAILED and SAVED UMA differences, we should record what's causing them and record status on a per-request basis to understand what is going on

This bug is to track a merge request. The CL in question is https://codereview.chromium.org/2751253004/
 

Comment 1 by chili@chromium.org, Mar 24 2017

Labels: Merge-Request-58
Please add applicable OSs.  Thanks!

Comment 3 by chili@chromium.org, Mar 24 2017

Labels: OS-Android
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 25 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd

commit 8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd
Author: Pete Williamson <petewil@chromium.org>
Date: Mon Mar 27 18:36:19 2017

[Offline Pages] Add UMA to record final offline request status and loading failed error code.

BUG= 704999 

Review-Url: https://codereview.chromium.org/2751253004
Cr-Commit-Position: refs/heads/master@{#458001}
(cherry picked from commit 642d1848697b731de396d6df1577443e33e17ad0)

Review-Url: https://codereview.chromium.org/2779783002 .
Cr-Commit-Position: refs/branch-heads/3029@{#433}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/components/offline_pages/core/background/request_notifier.h
[modify] https://crrev.com/8b28e3a4dc7090a2ad9cbcf66fc427d941b8c1dd/tools/metrics/histograms/histograms.xml

Sign in to add a comment