New issue
Advanced search Search tips

Issue 704993 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

CQ can't apply patch but bots can

Project Member Reported by jam@chromium.org, Mar 24 2017

Issue description

I sent a change out for trybots 16 hours ago: https://codereview.chromium.org/2768933004/#ps20001
It applied fine, even with retries that just succeeded now. However after it got ready to commit, the CQ said it couldn't apply the patch. The conflict was from a patch that landed 27 hours ago (https://codereview.chromium.org/2735183003), so I'm surprised that the CQ has different patching logic?
 

Comment 1 by jam@chromium.org, Mar 24 2017

btw git cl land also worked.
Cc: tandrii@chromium.org
Components: -Infra>CQ Infra>Platform>CQdaemon
Labels: -OS-Windows
Status: Available (was: Unconfirmed)
I'm 99% sure this is because we disabled 3-way merge in CQ, but not on bots.
See also  issue 678172 .

I think we can re-enable 3-way merge now: https://chrome-internal-review.googlesource.com/c/340044
Owner: tandrii@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/af9b202bd2a4c57742dd374030e02404f93002cd

commit af9b202bd2a4c57742dd374030e02404f93002cd
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Mar 27 17:40:03 2017

Status: Fixed (was: Started)

Comment 6 by jam@chromium.org, Apr 4 2017

Labels: OS-Windows
Thanks!
Cc: chrishall@chromium.org dominickn@chromium.org aga...@chromium.org
 Issue 678172  has been merged into this issue.

Sign in to add a comment