New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704985 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add ability to run chrome for chromeos with mus but chrome and ash still in the same process

Project Member Reported by sky@chromium.org, Mar 24 2017

Issue description

The flag will be --mus. In this mode ash and chrome will run in the same process (the browser process), and mus will run in a separate process.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12a19e335d08d57c1517991c904c2390841cb105

commit 12a19e335d08d57c1517991c904c2390841cb105
Author: sky <sky@chromium.org>
Date: Fri Mar 24 23:40:36 2017

Adds the ability to run chromeos with mus

In this config the browser process contains chrome and ash. Mus is in
a separate process. This patch is just the plumbing for the switch and
detection, it doesn't actually work yet.

BUG= 704985 
TEST=none
R=rockot@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2775873002
Cr-Commit-Position: refs/heads/master@{#459599}

[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/BUILD.gn
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/chrome_main.cc
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/mash/chrome_mash_manifest.json
[add] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/mash/chrome_mus_manifest.json
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/common/chrome_switches.cc
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/common/chrome_switches.h
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/test/BUILD.gn
[modify] https://crrev.com/12a19e335d08d57c1517991c904c2390841cb105/chrome/test/base/mojo_test_connector.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a

commit 494c6cbdea529cc6aa1e4e344bdc732d61d91d3a
Author: sky <sky@chromium.org>
Date: Mon Mar 27 20:57:48 2017

Gets chrome --mus some what working

This makes chrome work in --mus mode. It comes up and displays stuff,
but I have no doubt a bunch of stuff doesn't work.

BUG= 704985 , 705592 , 705595 , 705591 , 678949 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2777223002
Cr-Commit-Position: refs/heads/master@{#459875}

[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/common/wm_shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager_application.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/test/ash_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.cc
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.h

Comment 5 by sky@chromium.org, Mar 30 2017

Status: Fixed (was: Started)
This is done, you can now run mushrome mode with --mus.

Comment 6 by fw...@igalia.com, Apr 3 2017

Cc: msi...@igalia.com fw...@igalia.com toniki...@igalia.com

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment