New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704978 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 704755



Sign in to add a comment

[Android O] Break out notification channels from the Browser channel

Project Member Reported by awdf@chromium.org, Mar 24 2017

Issue description

The current proposal is for Downloads, Media and Incognito notifications to each have their own channel, within the General channel group, and retain the Browser channel for all other Chrome-generated notifications.

See https://docs.google.com/document/d/1K9pjvlHF1oANNI8TqZgy151tap9zs1KUr2qfBXo1s_4/edit# for more info.
 

Comment 1 by awdf@chromium.org, Mar 24 2017

Labels: -OS-Linux

Comment 2 by awdf@chromium.org, Mar 29 2017

Description: Show this description

Comment 3 by awdf@chromium.org, Apr 11 2017

Cc: rolfe@chromium.org sfiera@chromium.org
Mocks are at https://folio.googleplex.com/chrome-ux/mocks/428-o-notifications/032317_Flow#%2F01_Comparison.png%3Fz=width 

rolfe@ - can you confirm those strings in the mocks are the final ones that passed strings review? :
- Browser
- Downloads
- Incognito
- Media
- Sites (until split out in https://bugs.chromium.org/p/chromium/issues/detail?id=700377)

Also what was the final string for 'Content suggestions'?
(cc sfiera@ who may end up implementing this one)


Comment 4 by rolfe@chromium.org, Apr 11 2017

Confirming all strings! Also "Content suggestions" was the final one for that one too.

Comment 5 by awdf@chromium.org, Apr 12 2017

Labels: M-59

Comment 6 by awdf@chromium.org, Apr 12 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ecaeb804b4aab2c9aad6953954705499d2ad4a1

commit 0ecaeb804b4aab2c9aad6953954705499d2ad4a1
Author: awdf <awdf@chromium.org>
Date: Wed Apr 12 17:54:56 2017

[Android O] Split out browser notification channels

- Incognito, Media, and Download notifications are all now posted
to their own special channels, which are created on startup.

- The Browser channel remains for all other misc browser notifications.

BUG= 704978 

Review-Url: https://codereview.chromium.org/2814603003
Cr-Commit-Position: refs/heads/master@{#464079}

[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsInitializer.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsInitializerTest.java
[modify] https://crrev.com/0ecaeb804b4aab2c9aad6953954705499d2ad4a1/chrome/android/junit/src/org/chromium/chrome/browser/notifications/ChannelsUpdaterTest.java

Comment 8 by rolfe@chromium.org, Apr 14 2017

Cc: -rolfe@chromium.org chowse@chromium.org
Removing myself and adding chowse@ as your trusty design contact

Comment 9 by awdf@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
Resolving this bug as fixed - content suggestions are not broken out yet but leaving that to sfiera@ to land when appropriate.

Comment 10 by awdf@chromium.org, Apr 21 2017

Blocking: 704755

Sign in to add a comment