New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704971 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 697864



Sign in to add a comment

RendererCompositorFrameSink needs to directly get BeginFrames

Project Member Reported by samans@chromium.org, Mar 24 2017

Issue description

Currently BeginFrame IPC messages go to CompositorExternalBeginFrameSource. Once RendererCompositorFrameSink is a MojoCompositorFrameSinkClient, it is going to get BeginFrames directly and it needs to be able to directly handle them.
 

Comment 1 by samans@chromium.org, Mar 24 2017

The same applies to sending BeginFrame-related messages (such as SetNeedsBeginFrames) as well.

Comment 2 by samans@chromium.org, Mar 24 2017

Blocking: 697864
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09812d36f72be34ba5e68441222750b4b0a6b3a9

commit 09812d36f72be34ba5e68441222750b4b0a6b3a9
Author: samans <samans@chromium.org>
Date: Mon Mar 27 19:57:43 2017

RendererCompositorFrameSink should receive BeginFrame messages

Currently, BeginFrame messsages are routed to
CompositorExternalBeginFrameSource. Once we switch to
MojoCompositorFrameSinkClient, we can't have ReclaimResources
messages go to one class and BeginFrame messages go to another.
RendererCompositorFrameSink must handle all BeginFrame-related messages.

BUG= 704971 

Review-Url: https://codereview.chromium.org/2773023002
Cr-Commit-Position: refs/heads/master@{#459859}

[modify] https://crrev.com/09812d36f72be34ba5e68441222750b4b0a6b3a9/content/renderer/gpu/renderer_compositor_frame_sink.cc
[modify] https://crrev.com/09812d36f72be34ba5e68441222750b4b0a6b3a9/content/renderer/gpu/renderer_compositor_frame_sink.h
[modify] https://crrev.com/09812d36f72be34ba5e68441222750b4b0a6b3a9/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/09812d36f72be34ba5e68441222750b4b0a6b3a9/content/renderer/render_thread_impl.h

Comment 4 by fsamuel@google.com, Oct 24 2017

Owner: samans@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment