[Media Router] When starting presentation, dialog should say "Cast" instead of "Cast to" |
|||||||||
Issue descriptionChrome Version: OS: Linux (applies to all desktop) What steps will reproduce the problem? (1) Visit https://googlechrome.github.io/samples/presentation-api/ (2) Click "new PresentationRequest" then "start" (3) Observe dialog What is the expected result? Dialog says "Cast googlechrome.github.io" What happens instead? Dialog says "Cast to" with no origin/destination (1) This is a polish issue, the user has indicated they want to present, that should be the default mode in the picker. (2) It violates the enamel guidelines to not show the origin requesting presentation by default. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 29 2017
I'll follow up with Stephen on this, it's an ongoing conversation.
,
Apr 24 2017
As a start, let's make this the default when presentation is requested from an iframe.
,
May 5 2017
Issue 667881 has been merged into this issue.
,
May 5 2017
,
May 8 2017
I have a patch up to address this, https://codereview.chromium.org/2862393002 However it's unsatisfying in two respects: 1. The patch has to plumb a flag all the way from the PresentationService deep into the WebUI code to special case requests from iframes. This adds extra complexity to an already-complex flow. 2. Users will probably be confused as to why some presentations behave differently (they likely have no idea whether it was started from an iframe or not). The code and the UX could be made simpler by handling all presentation requests from content the same. WDYT Stephen?
,
May 8 2017
So the idea would be to always show the origin, regardless of whether it was invoked from the top-level or an iframe? I think that would be fine.
,
May 10 2017
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeb1406b336d5834d9362fad5e16af8ca45e6f0e commit eeb1406b336d5834d9362fad5e16af8ca45e6f0e Author: mfoltz <mfoltz@chromium.org> Date: Fri May 19 21:35:17 2017 Force DEFAULT cast mode when starting presentation from content. The Presentation API spec recommends that the origin requesting presentation be shown to the user when PresentationRequest.start() is called. This patch sets a new flag on a CastMode, isForced, that will cause the cast mode picker to show it initially when it is rendered. This flag is set when the Media Router UI is initialized from a PresentationRequest (e.g., from PresentationRequest.start()). There are a few cleanups that could be done as followup changes: - DEFAULT cast mode is more logically PRESENTATION since the request can come from any PresentationRequest (not just the page-default one). - CreatePresentationConnectionRequest and PresentationRequest are very similar and could be combined. - A default content::PresentationError is initialized with type NO_AVAILABLE_SCREENS. It would seem more logical to initialize with type UNKNOWN. TBR jam@ for a comment only change to presentation_info.h. BUG= 704964 TBR=jam CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2862393002 Cr-Commit-Position: refs/heads/master@{#473330} [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/media/router/create_presentation_connection_request.h [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/resources/media_router/media_router_data.js [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_cast_mode.h [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_ui.cc [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_ui.h [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/chrome/test/data/webui/media_router/media_router_container_test_base.js [modify] https://crrev.com/eeb1406b336d5834d9362fad5e16af8ca45e6f0e/content/public/common/presentation_info.h
,
May 26 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mfo...@chromium.org
, Mar 24 2017