New issue
Advanced search Search tips

Issue 704961 link

Starred by 1 user
Status: Duplicate
Merged: issue 713891
Owner: ----
Closed: Jun 2017
Cc:
atotic@chromium.org
ccameron@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac pngs should be srgb instead of rgb to match linux/win.

Project Member Reported by qyears...@chromium.org, Mar 24 2017 
This is a task from http://bit.ly/blink-infra added in February 2016, and there is a related TODO in the code at:
https://cs.chromium.org/chromium/src/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc?l=227

ccameron@, is this still something we want to do? What would this involve overall, and what is the next step?

Comment 1 by ccameron@chromium.org, Mar 24 2017 

We're enabling more robust color correction soon. For that, we will need to rebaseline every image on Mac.

So, at that point we should decide if we want to make them all match, or if we want all platforms to be slightly different, to ensure that we get better coverage.

Comment 2 by atotic@chromium.org, May 26 2017

Cc: atotic@chromium.org
Another data point from test suite:
web-platform-tests have reference tests. For example:
/LayoutTests/external/wpt/css/CSS2/positioning/bottom-applies-to-006.xht

this particular test compares:
background: green;
to:
background: url("support/green_box.png")

On my linux box, they both map to #008000

Comment 3 by ccameron@chromium.org, Jun 1 2017

Mergedinto: 713891
Status: Duplicate (was: Available)
Aha! This will finally be conquered with  issue 713891 .
►

Sign in to add a comment