New issue
Advanced search Search tips

Issue 704958 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Media Router] Move mojom files out of chrome/browser/

Project Member Reported by imch...@chromium.org, Mar 24 2017

Issue description

Context: https://codereview.chromium.org/2727123002/

To remove the dependency from extensions/ to chrome/browser, we will move our mojom files to a different directory. The current thinking is that it will go into media/mojo/interfaces.

For consistency we should also move the definition of struct traits and typemaps into the same directory, but that will also require us to move some of our C++ data structures (e.g. MediaSink).
 
Cc: taku...@chromium.org
Cc: -taku...@chromium.org
Owner: taku...@chromium.org
Status: Assigned (was: Untriaged)
Takumi is going to take this on.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34e5193d3994da1e822b7259462ab3c67a14467

commit a34e5193d3994da1e822b7259462ab3c67a14467
Author: takumif <takumif@chromium.org>
Date: Wed Apr 19 20:38:00 2017

Move c/b/media/router/mojo/*.mojom to chrome/common/media_router/mojo/*.mojom

We have a file in extensions/ [1] that depends on Media Router mojo definitions
from chrome/browser/. To remove this dependency from extensions/ to
chrome/browser/, this CL moves that file to chrome/renderer/, and Media Router
mojo interfaces to chrome/common/media_router/mojo/. Media Router typemaps and
related C++ structs are also moved to chrome/common/media_router/.

[1] extensions/renderer/resources/media_router_bindings.js

BUG= 704958 

Review-Url: https://codereview.chromium.org/2771413003
Cr-Commit-Position: refs/heads/master@{#465734}

[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/android/router/media_router_android_bridge.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/cast_remoting_connector.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/cast_remoting_connector.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/issue_manager.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/issues_observer.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_routes_observer.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_sink_service.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_route_controller.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/mojo/media_router_mojo_test.h
[delete] https://crrev.com/cb7c7859e8e84236d85aca12005c22ce707ebee4/chrome/browser/media/router/mojo/media_status.typemap
[delete] https://crrev.com/cb7c7859e8e84236d85aca12005c22ce707ebee4/chrome/browser/media/router/mojo/typemaps.gni
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/offscreen_presentation_manager.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/route_message_observer.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/cast_modes_with_media_sources.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/cast_modes_with_media_sources_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/media_sink_with_cast_modes.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/OWNERS
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/discovery/media_sink_internal.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/discovery/media_sink_internal.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/discovery/media_sink_internal_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/issue.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/issue.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/issue_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_route.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_route.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_route_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_sink.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_sink.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_sink_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source_helper.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source_helper.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source_helper_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_source_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_status.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/media_status.h
[add] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/BUILD.gn
[add] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/OWNERS
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/dial_device_description_parser.mojom
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_controller.mojom
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router.mojom
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router.typemap
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router_struct_traits.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router_struct_traits.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router_struct_traits_unittest.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_router_traits_test_service.mojom
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_status.mojom
[add] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_status.typemap
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_status_struct_traits.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/media_status_struct_traits.h
[add] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/mojo/typemaps.gni
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/route_message.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/route_message.h
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/route_request_result.cc
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/common/media_router/route_request_result.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/renderer/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/renderer/resources/extensions/OWNERS
[rename] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/renderer/resources/extensions/media_router_bindings.js
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/renderer/resources/renderer_resources.grd
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/test/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/chrome/utility/media_router/dial_device_description_parser_impl.h
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/extensions/BUILD.gn
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/extensions/renderer/dispatcher.cc
[delete] https://crrev.com/cb7c7859e8e84236d85aca12005c22ce707ebee4/extensions/renderer/resources/OWNERS
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/a34e5193d3994da1e822b7259462ab3c67a14467/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/678822e951c8943cc2b80657eeaec130d82b7385

commit 678822e951c8943cc2b80657eeaec130d82b7385
Author: thakis <thakis@chromium.org>
Date: Thu Apr 20 17:20:34 2017

Remove enable_media_router.

It was set to false only on iOS and cast, but the define is mostly used
in chrome/ which isn't used in neither iOS nor cast builds.

No intended behavior change.

BUG= 461815 , 704958 
TBR=cpu

Review-Url: https://codereview.chromium.org/2760403003
Cr-Commit-Position: refs/heads/master@{#466043}

[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/build/config/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/build/config/features.gni
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/app/generated_resources.grd
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/about_flags.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/browser_resources.grd
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/extensions/chrome_mojo_service_registration.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/extensions/external_component_loader.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/media/router/media_router_ui_service_factory.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/prefs/pref_service_syncable_util.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/extensions/extension_constants.h
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/pref_names.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/pref_names.h
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/url_constants.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/common/url_constants.h
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/renderer/resources/renderer_resources.grd
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/test/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/chrome/utility/BUILD.gn
[modify] https://crrev.com/678822e951c8943cc2b80657eeaec130d82b7385/tools/grit/grit_rule.gni

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd90c4719b46692c8eee8279cf1dc8894356845a

commit cd90c4719b46692c8eee8279cf1dc8894356845a
Author: takumif <takumif@chromium.org>
Date: Thu Apr 20 20:59:00 2017

[Media Router] Remove duplicate entries in BUILD

These seven Media Router unit test files were listed both in
chrome/test/BUILD.gn and chrome/common/media_router/BUILD.gn. This CL removes
them from the latter.

BUG= 704958 

Review-Url: https://codereview.chromium.org/2834573003
Cr-Commit-Position: refs/heads/master@{#466125}

[modify] https://crrev.com/cd90c4719b46692c8eee8279cf1dc8894356845a/chrome/common/media_router/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment