New issue
Advanced search Search tips

Issue 704955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 745778



Sign in to add a comment

Sample rate for some layout tests are too low

Project Member Reported by rtoy@chromium.org, Mar 24 2017

Issue description

Some layout tests use a sample rate of 4096.  While Chrome supports this, the spec says only sample rates of 8000 and higher are required.

We need to increase these rates to be within the required spec limits.  This will be important if we want to move these tests to WPT.

Some of the tests with sample rates too low:

AudioBufferSource/audiobuffersource-loop-grain-no-duration.html
AudioBufferSource/audiobuffersource-playbackrate-zero.html
AudioBufferSource/audiobuffersource-premature-loop-stop.html
AudioParam/audioparam-linearRamp-value-attribute.html


 

Comment 1 by rtoy@chromium.org, Jul 19 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 2 by rtoy@chromium.org, Jul 19 2017

Blocking: 745778
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66638bfc76ac48ae57b53fc131cec926e5e8c2df

commit 66638bfc76ac48ae57b53fc131cec926e5e8c2df
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Jul 24 20:07:43 2017

Increase sample rate of tests to 8192

These tests use a sample rate of 4096 which is supported by Chrome.
But the spec says the minimum required rate is 8000.  To be able to
upstream these tests, we need to increase the sample rate.  Make it
8192.

Bug:  704955 
Test: AudioBufferSource/audiobuffersource-loop-grain-no-duration.html, AudioBufferSource/audiobuffersource-playbackrate-zero.html, AudioBufferSource/audiobuffersource-premature-loop-stop.html, AudioParam/audioparam-linearRamp-value-attribute.html
Change-Id: Ic63d0ed5df65cfecfc27e87df05460aa749d7600
Reviewed-on: https://chromium-review.googlesource.com/578228
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489060}
[modify] https://crrev.com/66638bfc76ac48ae57b53fc131cec926e5e8c2df/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html
[modify] https://crrev.com/66638bfc76ac48ae57b53fc131cec926e5e8c2df/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html
[modify] https://crrev.com/66638bfc76ac48ae57b53fc131cec926e5e8c2df/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html
[modify] https://crrev.com/66638bfc76ac48ae57b53fc131cec926e5e8c2df/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRamp-value-attribute.html

Comment 4 by rtoy@chromium.org, Jul 25 2017

Status: Fixed (was: Started)

Sign in to add a comment