Issue metadata
Sign in to add a comment
|
Better coverage for QuicStreamFactory and HttpStreamFactoryImpl in MemoryDumpProvider |
||||||||||||||||||||||||
Issue descriptionThis is to follow up on Issue 700617 . net/ MemoryDumpProvider does an okay job in tracking QuicStreamFactory. However, the magnitude is off. We need to investigate if we can improve coverage there. See the screenshot attached below. It attributes 9MB to QuicStreamFactory ("stream_factory" row). The number is one order off.
,
Mar 24 2017
The trace is at https://drive.google.com/a/google.com/file/d/0B6ho_7_ut5e1dXVnTGx6d0ExLWs/view?usp=sharing It shows that net::HttpStreamFactoryImpl::RequestStreamInternal is responsible for 90737 KiB of live bytes spread across 19953 jobs. The other stack where the jobs are allocated runs out of frames, so we can only see the size of half of the jobs. Heap profiler gives us 90MB, so that means net MDP is one order off. Just to double check. Does the 90MB include tracing overhead?
,
Mar 24 2017
The 90MB does not include tracing overhead. It is an accurate representation of memory being used.
,
Mar 24 2017
The shown stack trace should not include any tracing overhead unless there are some TRACE_EVENT(s) in the net code. You can increase the stack trace limit and run the experiment again to see full stack traces, since the issue is reproducible on custom builds.
,
Mar 24 2017
This trace has a much larger stack limit. The leak is not as large [only 4k alt jobs]. https://drive.google.com/a/google.com/file/d/0B6ho_7_ut5e1NVlfWEdMeVZHRms/view?usp=sharing
,
Apr 4 2017
,
Apr 4 2017
,
Apr 5 2017
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/385c750bda55aeca96a2b55c30d1f56b6a816f57 commit 385c750bda55aeca96a2b55c30d1f56b6a816f57 Author: xunjieli <xunjieli@chromium.org> Date: Wed Apr 05 17:24:23 2017 Remove an unused QuicStreamFactory::Job constructor Removes an unused Job constructor and add const-ness to a few member fields. BUG= 704953 Review-Url: https://codereview.chromium.org/2789403002 Cr-Commit-Position: refs/heads/master@{#462130} [modify] https://crrev.com/385c750bda55aeca96a2b55c30d1f56b6a816f57/net/quic/chromium/quic_stream_factory.cc
,
Apr 10 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48e4f10eb4784c4cf1bd09efde38a86457faece2 commit 48e4f10eb4784c4cf1bd09efde38a86457faece2 Author: xunjieli <xunjieli@chromium.org> Date: Tue Apr 11 23:06:53 2017 Track STL containers in QuicStreamFactory::DumpMemoryStats This CL includes QuicStreamFactory's STL containers in DumpMemoryStats(). This should let us know if any of them grows too big and causes problems. BUG= 704953 Review-Url: https://codereview.chromium.org/2807493002 Cr-Commit-Position: refs/heads/master@{#463821} [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/BUILD.gn [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/http/disk_cache_based_quic_server_info.cc [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/http/disk_cache_based_quic_server_info.h [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/properties_based_quic_server_info.cc [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/properties_based_quic_server_info.h [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/quic_server_info.h [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/chromium/quic_stream_factory_test.cc [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/core/quic_server_id.cc [modify] https://crrev.com/48e4f10eb4784c4cf1bd09efde38a86457faece2/net/quic/core/quic_server_id.h
,
Jul 17 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ssid@chromium.org
, Mar 24 2017Components: Internals>Instrumentation>Memory