New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704946 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Allow framework style includes in ios/web_view/shell.

Project Member Reported by michaeldo@chromium.org, Mar 24 2017

Issue description

The ios_web_view_shell depends upon ChromeWebView.framework which is built by ios/web_view:web_view. However, framework includes (like "#import <ChromeWebView/CWVWebView.h>") are not working.
 
Also allow framework style include while building the framework itself (//ios/web_view).
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5376139411f2b362d24abc27425f3827697a46d4

commit 5376139411f2b362d24abc27425f3827697a46d4
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Mar 28 12:44:55 2017

[ios] Add framework_dir flag to all_dependent_configs (-F).

When building a custom framework, the framework and the framework_dir
flags need to be added to the command-line of every linkable target
the depends directly or indirectly on it. GN propagates properly the
framework as it knows about "libs", but the -F flag added to ldflags
need to be propagated using all_dependent_configs.

BUG= 704946 

Review-Url: https://codereview.chromium.org/2778813002
Cr-Commit-Position: refs/heads/master@{#460071}

[modify] https://crrev.com/5376139411f2b362d24abc27425f3827697a46d4/build/config/ios/rules.gni

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8ebc9543e8def157337ed491463c55fd45c785

commit 5d8ebc9543e8def157337ed491463c55fd45c785
Author: michaeldo <michaeldo@chromium.org>
Date: Thu Mar 30 09:49:40 2017

Remove CWV_IMPLEMENTATION hack.

BUG= 704946 

Review-Url: https://codereview.chromium.org/2782253002
Cr-Commit-Position: refs/heads/master@{#460713}

[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_delegate.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_html_element.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_navigation_action.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_navigation_delegate.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_translate_delegate.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_translate_manager.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_ui_delegate.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_user_content_controller.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_user_script.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/5d8ebc9543e8def157337ed491463c55fd45c785/ios/web_view/public/cwv_web_view_configuration.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b48b353161948224246626099272017cb9fbbb4f

commit b48b353161948224246626099272017cb9fbbb4f
Author: michaeldo <michaeldo@chromium.org>
Date: Mon Apr 03 18:56:38 2017

Use framework style includes in ios/web_view/public.

BUG= 704946 

Review-Url: https://codereview.chromium.org/2791323002
Cr-Commit-Position: refs/heads/master@{#461494}

[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/build/config/ios/rules.gni
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/BUILD.gn
[delete] https://crrev.com/3e89c40768f9ed6488cd9d468b3a3e6fea3ec137/ios/web_view/internal/BUILD.gn
[delete] https://crrev.com/3e89c40768f9ed6488cd9d468b3a3e6fea3ec137/ios/web_view/internal/translate/BUILD.gn
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/internal/web_view_url_request_context_getter.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/internal/web_view_web_main_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/internal/web_view_web_main_parts.h
[delete] https://crrev.com/3e89c40768f9ed6488cd9d468b3a3e6fea3ec137/ios/web_view/public/BUILD.gn
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/ChromeWebView.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_html_element.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_navigation_action.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_navigation_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_translate_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_translate_manager.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_ui_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_user_content_controller.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_user_script.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/public/cwv_web_view_configuration.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/shell/shell_delegate.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/shell/translate_controller.h
[modify] https://crrev.com/b48b353161948224246626099272017cb9fbbb4f/ios/web_view/shell/translate_controller.m

Sign in to add a comment