New issue
Advanced search Search tips

Issue 704945 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 1
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add the time when the user sees the Browser UI for the first time metric

Reported by mbl...@yandex-team.ru, Mar 24 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 YaBrowser/17.3.1.594 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
AFAIK currently there are Startup.BrowserWindowDisplay and Startup.FirstWebContents.NonEmptyPaint2, but they don't measure the moment when the actual Browser UI becomes visible for the user.

The time it takes for GPU to paint the initial frame could be not trivial and should be tracked.

What is the expected behavior?

What went wrong?
Startup.BrowserWindowDisplay is measured during Browser::OnWindowDidShow(), but the delay before the UI is actually visible on screen is quite large (1052.0 vs 2871.0 on my MacViews build of the Yandex.Browser).

Proposed CL: https://codereview.chromium.org/2773973002/

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: n/a
OS Version: OS X 10.12.3
Flash Version:
 

Comment 1 by shrike@chromium.org, Mar 24 2017

Labels: OS-Linux OS-Windows
Status: Started (was: Unconfirmed)
Here's how the proposed histogram compares to Startup.BrowserWindowDisplay: ~0.5s difference on a MacViews debug build.

Relative to the Startup.FirstWebContents.NonEmptyPaint2 it is ~0.8s apart, but this time depends on the URL of the active tab.
Screen Shot 2017-03-31 at 16.48.35.png
146 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cfcb7cdbff23b208c96b7da2f42689421c4586e

commit 3cfcb7cdbff23b208c96b7da2f42689421c4586e
Author: mblsha <mblsha@yandex-team.ru>
Date: Thu Apr 20 14:59:39 2017

Add Startup.BrowserView.FirstPaint / .CompositingEnded histograms.

Startup.BrowserView.FirstPaint measures how long does it take from browser
startup until BrowserView finished the initial paint of all its children.

Startup.BrowserView.CompositingEnded measures the time from browser startup
to the time the GPU has finished compositing after BrowserView has finished
painting its children. At this point the Browser interface is visible on
screen. Measures how much time does it take for GPU to actually paint the
first time.

BUG= 704945 , 589118 

Review-Url: https://codereview.chromium.org/2773973002
Cr-Commit-Position: refs/heads/master@{#466009}

[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/BUILD.gn
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/background/background_mode_manager.cc
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/chrome_browser_main.cc
[add] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/metrics/browser_window_histogram_helper.cc
[add] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/metrics/browser_window_histogram_helper.h
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/metrics/first_web_contents_profiler.cc
[add] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/metrics/startup_metrics_browsertest.cc
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/chrome/test/BUILD.gn
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/components/startup_metric_utils/browser/startup_metric_utils.cc
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/components/startup_metric_utils/browser/startup_metric_utils.h
[modify] https://crrev.com/3cfcb7cdbff23b208c96b7da2f42689421c4586e/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment