New issue
Advanced search Search tips

Issue 704943 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ChromeSitePerProcessAutofillTest.AutofillClientPositionWhenInsideOOPIF is flaky

Project Member Reported by ekaramad@chromium.org, Mar 24 2017

Issue description

The test seems to be flaking quite frequently now.
 
I think the test should live in site_per_process_interactive_tests.cc to being with since it relies on a keyboard input being passed on to the renderer to make the warning appear.
Cc: vabr@chromium.org
cc-ing vabr@ since he might also be working on similar tests.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9febb1f84922d7307712a044550c9ad0640b64d3

commit 9febb1f84922d7307712a044550c9ad0640b64d3
Author: ekaramad <ekaramad@chromium.org>
Date: Fri Mar 24 20:26:02 2017

Rename AutofillClientPositionWhenInsideOOPIF and move it to interactive tests

The test is currently flaking on different platforms. The failure is due
to incorrect boudns reported either through focused node change event,
or AutofillClient. The failure is hard to reporoduce locally and the
logs do not provde proper visibility as to what the root cause could be.

This CL will:
  1- Move the test from browser_tests to interactive_ui_tests.
  2- Renames the test move appropriately to address vabr@'s comment in the
  original CL https://codereview.chromium.org/2754033002 (we are testing
  a popup position and the term "AutofillClient" is incorrect).
  3- Adds a log when the test fails to show the focused node bouds as
  well as those reported by autofill client and give us a hint on which
  one might be incorrect.

BUG= 704943 , 686129 

Review-Url: https://codereview.chromium.org/2773823003
Cr-Commit-Position: refs/heads/master@{#459535}

[modify] https://crrev.com/9febb1f84922d7307712a044550c9ad0640b64d3/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/9febb1f84922d7307712a044550c9ad0640b64d3/chrome/browser/site_per_process_interactive_browsertest.cc

The new test is still flaky. I believe the conversion of local coordinates to root coordinates for FocusNodeChanged is not doing its job properly. I am working on a way to wait for those transformations be valid which should theoretically fix the flake.
Cc: alex...@chromium.org
 Issue 705914  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d112490bb36604ec3f89951188d41fa111ea248

commit 0d112490bb36604ec3f89951188d41fa111ea248
Author: ekaramad <ekaramad@chromium.org>
Date: Tue Mar 28 22:08:35 2017

Modify a test to wait for compositor frame of OOPIF synced with CSS modifications in parent process

A recent test which compares bounds reported from a focused node inside
OOPIF against those reported for the same element throught AutofillAgent
falkes 15% of the time. The reason seems to be that transforming the
node bounds from child frame coordinates to root frame coordinates is
failing for the focused node (which comes first and before autofill's
update). The root cause is most probably a delayed updated in compositor
frame's metadata for the OOPIF.

This CL will modify the test so that we will wait for a known transform
to happen, that is, for a fixed position frame and no border,
transforming (0, 0) to root view should (almost) return the left and top
properties of the frame (which we set).

BUG= 704943 

Review-Url: https://codereview.chromium.org/2781903002
Cr-Commit-Position: refs/heads/master@{#460219}

[modify] https://crrev.com/0d112490bb36604ec3f89951188d41fa111ea248/chrome/browser/site_per_process_interactive_browsertest.cc

Comment 8 by st...@chromium.org, Apr 4 2017

Labels: -AnalyzedByFindit Test-Findit-Analyzed
Status: Fixed (was: Started)
The test seems to have stopped flaking. Closing this bug.
Cc: -vabr@chromium.org

Sign in to add a comment