New issue
Advanced search Search tips

Issue 704941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove support for old opener-opened relationship serialisation code

Project Member Reported by sdefresne@chromium.org, Mar 24 2017

Issue description

Serialisation code for Tab opener-opened relationship was updated in https://codereview.chromium.org/2771863002/ with support code to deserialise the old format.

Migration code should be removed once it is deemed unlikely to cause too much pain to users. Either track this with a histogram or use the an heuristic that no user is using version x anymore.

Migration code was introduced between M-58 & M-59.

 
Labels: Hotlist-Needs-New-Component
Components: UI>Browser>Sessions
Labels: -Hotlist-Needs-New-Component
Project Member

Comment 3 by sheriffbot@chromium.org, May 31 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: eugene...@chromium.org
Labels: M-69
Status: Available (was: Untriaged)
I think we said that we wanted to unwind the legacy support 10 versions after being released, so I'm marking this as available for M69.
Cc: kkhorimoto@chromium.org
Labels: -Type-Bug Hotlist-GoodFirstBug Type-Task
M68 has branched, so we can remove this code on trunk. Kurt, do you want to take this issue?
Owner: sdefresne@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6812b62df5817bb66f3701ce0164f74f4a2ec01

commit f6812b62df5817bb66f3701ce0164f74f4a2ec01
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Aug 02 12:55:09 2018

Remove obsolete code in WebStateList deserialization

The properties used to serialize the WebStateList opener-opened
relationship was changed in M-59, so the support for the legacy
format can be dropped now that M-69 has been branched.

Bug:  704941 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I63180a9be5d47a507ddcb5c1c37f6b3512cbfa94
Reviewed-on: https://chromium-review.googlesource.com/1158696
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580147}
[modify] https://crrev.com/f6812b62df5817bb66f3701ce0164f74f4a2ec01/ios/chrome/browser/web_state_list/web_state_list_serialization.mm
[modify] https://crrev.com/f6812b62df5817bb66f3701ce0164f74f4a2ec01/ios/web/navigation/serializable_user_data_manager_impl.mm

Status: Fixed (was: Started)

Sign in to add a comment