Rotation change from chrome.system.display in TouchView mode |
||||||||||||||
Issue descriptionChanging rotation using chrome.system.display should be treated as if user rotation lock in touch view. * It may not be able to rotate to that direction. * Yet, it should be honored when possible.
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5bd9a545c026646b4f9bc35aba650ff01c87edd commit c5bd9a545c026646b4f9bc35aba650ff01c87edd Author: warx <warx@chromium.org> Date: Mon Apr 03 22:30:12 2017 cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock Changes: Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock. BUG= 704931 TEST=test coverage Review-Url: https://codereview.chromium.org/2784043002 Cr-Commit-Position: refs/heads/master@{#461559} [modify] https://crrev.com/c5bd9a545c026646b4f9bc35aba650ff01c87edd/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/c5bd9a545c026646b4f9bc35aba650ff01c87edd/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/c5bd9a545c026646b4f9bc35aba650ff01c87edd/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/c5bd9a545c026646b4f9bc35aba650ff01c87edd/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
,
Apr 3 2017
Merge request for M-58
,
Apr 3 2017
Merge approved for 58.
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae235144d5ef8313dfc90d70e3204b7625a60342 commit ae235144d5ef8313dfc90d70e3204b7625a60342 Author: Qiang Xu <warx@chromium.org> Date: Mon Apr 03 23:42:20 2017 [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock Changes: Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock. TBR=oshima@chromium.org, lazyboy@chromium.org BUG= 704931 TEST=test coverage Review-Url: https://codereview.chromium.org/2784043002 Cr-Commit-Position: refs/heads/master@{#461559} (cherry picked from commit c5bd9a545c026646b4f9bc35aba650ff01c87edd) Review-Url: https://codereview.chromium.org/2790073003 . Cr-Commit-Position: refs/branch-heads/3029@{#558} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/ae235144d5ef8313dfc90d70e3204b7625a60342/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/ae235144d5ef8313dfc90d70e3204b7625a60342/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/ae235144d5ef8313dfc90d70e3204b7625a60342/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/ae235144d5ef8313dfc90d70e3204b7625a60342/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
,
Apr 3 2017
,
Apr 4 2017
This appears to have broken the Chrome build on R58. Should this be reverted or is there a quick fix? https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/145/steps/BuildPackages/logs/stdio ... chromeos-chrome-58.0.3029.52_rc-r1: FAILED: obj/chrome/browser/extensions/extensions/display_info_provider_chromeos.o chromeos-chrome-58.0.3029.52_rc-r1: x86_64-cros-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/chrome/browser/extensions/extensions/display_info_provider_chromeos.o.d -DENABLE_HOTWORDING -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_DIRECTWRITE_GASP_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DMESA_EGL_NO_X11_HEADERS -DLEVELDB_PLATFORM_CHROMIUM=1 -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\" -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DRLZ_NETWORK_IMPLEMENTATION_CHROME_NET -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I/build/samus/usr/include/dbus-1.0 -I/build/samus/usr/lib64/dbus-1.0/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/boringssl/src/include -Igen/chrome -Igen/chrome -Igen/chrome -Igen/chrome -Igen/components/metrics/proto -I/build/samus/usr/include/nss -I/build/samus/usr/include/nspr -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit -Igen/third_party/WebKit -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Igen/v8/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/re2/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -Igen/ui/resources -Igen/ui/resources -Igen/extensions -Igen -Igen -Igen/components -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/cacheinvalidation/overrides -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/cacheinvalidation/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libaddressinput/src/cpp/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libaddressinput/chromium/override -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc_overrides -I../../../../../../../home/chrome-bot/chrome_root/src/third_party -Igen/components/chrome_apps -Igen/ui/views/resources -Igen/ui/file_manager -Igen/ui/keyboard -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -m64 -march=x86-64 -pthread -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../../../../../../build/samus -fvisibility=hidden -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -pipe -pipe -march=corei7 -D__google_stl_debug_vector=1 -c ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/display_info_provider_chromeos.cc -o obj/chrome/browser/extensions/extensions/display_info_provider_chromeos.o chromeos-chrome-58.0.3029.52_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/display_info_provider_chromeos.cc: In function 'bool extensions::{anonymous}::IsMaximizeModeWindowManagerEnabled()': chromeos-chrome-58.0.3029.52_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/display_info_provider_chromeos.cc:415:9: error: 'class ash::Shell' has no member named 'maximize_mode_controller' chromeos-chrome-58.0.3029.52_rc-r1: ->maximize_mode_controller() chromeos-chrome-58.0.3029.52_rc-r1: ^ chromeos-chrome-58.0.3029.52_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/display_info_provider_chromeos.cc:417:1: error: control reaches end of non-void function [-Werror=return-type] chromeos-chrome-58.0.3029.52_rc-r1: } chromeos-chrome-58.0.3029.52_rc-r1: ^ chromeos-chrome-58.0.3029.52_rc-r1: cc1plus: all warnings being treated as errors ...
,
Apr 4 2017
It is a compile error. I don't know why actually. Let me revert it first to not block M-58 build. I can go to a M-58 version to take investigation.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dbee700a85e03f3611607cd585eac218564c4ba commit 9dbee700a85e03f3611607cd585eac218564c4ba Author: warx <warx@chromium.org> Date: Tue Apr 04 17:00:22 2017 Revert of [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user … (patchset #1 id:1 of https://codereview.chromium.org/2790073003/ ) Reason for revert: CL breaks the M-58 build: https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/145/steps/BuildPackages/logs/stdio Original issue's description: > [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock > > Changes: > Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock. > > TBR=oshima@chromium.org, lazyboy@chromium.org > BUG= 704931 > TEST=test coverage > > Review-Url: https://codereview.chromium.org/2784043002 > Cr-Commit-Position: refs/heads/master@{#461559} > (cherry picked from commit c5bd9a545c026646b4f9bc35aba650ff01c87edd) > > Review-Url: https://codereview.chromium.org/2790073003 . > Cr-Commit-Position: refs/branch-heads/3029@{#558} > Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} > Committed: https://chromium.googlesource.com/chromium/src/+/ae235144d5ef8313dfc90d70e3204b7625a60342 TBR=lazyboy@chromium.org,oshima@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 704931 Review-Url: https://codereview.chromium.org/2795103003 Cr-Commit-Position: refs/branch-heads/3029@{#568} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/9dbee700a85e03f3611607cd585eac218564c4ba/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/9dbee700a85e03f3611607cd585eac218564c4ba/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/9dbee700a85e03f3611607cd585eac218564c4ba/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/9dbee700a85e03f3611607cd585eac218564c4ba/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
,
Apr 4 2017
MaximizeModeController is moved from WmShell to Shell in M59: https://codereview.chromium.org/2766543002 I would change ash::Shell::GetInstance() to ash::WmShell::Get() to do a merge again.
,
Apr 5 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 5 2017
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eee5372d66a84bf36087728f0c39ed087d92f4b commit 1eee5372d66a84bf36087728f0c39ed087d92f4b Author: Qiang Xu <warx@chromium.org> Date: Wed Apr 05 23:20:49 2017 [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock Changes: Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock. TBR=oshima@chromium.org, lazyboy@chromium.org BUG= 704931 TEST=test coverage Review-Url: https://codereview.chromium.org/2784043002 Cr-Commit-Position: refs/heads/master@{#461559} (cherry picked from commit c5bd9a545c026646b4f9bc35aba650ff01c87edd) Review-Url: https://codereview.chromium.org/2800963002 . Cr-Commit-Position: refs/branch-heads/3029@{#596} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/1eee5372d66a84bf36087728f0c39ed087d92f4b/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/1eee5372d66a84bf36087728f0c39ed087d92f4b/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/1eee5372d66a84bf36087728f0c39ed087d92f4b/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/1eee5372d66a84bf36087728f0c39ed087d92f4b/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
,
Apr 5 2017
,
May 24 2017
,
Aug 11 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by osh...@chromium.org
, Mar 27 2017