New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704923 link

Starred by 1 user
Status: Archived
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
omrilio@chromium.org
█ elizabethchiu@chromium.org
█ gkihumba@chromium.org
abodenha@chromium.org
█ kuscher@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Update the rotation lock UI

Project Member Reported by osh...@chromium.org, Mar 24 2017 
* Unlocked icon should always be visible in tablet mode
* Locked icon should have the specific direction.

In short, we want to make this consistent with stock Android's
lock icons.

Comment 1 by warx@chromium.org, Mar 28 2017

Cc: abodenha@chromium.org kuscher@chromium.org
We need new tray detailed-view images, which I explained more in this doc: https://docs.google.com/document/d/1MMjq-NszYOpYJKR_btpPtWCkLW9-qemhhHHzN_1uyRw/edit

+kuscher, +abodenha, could you help me find a UI/UX designer to prepare those UI images?

Comment 2 by warx@chromium.org, Mar 29 2017

Cc: omrilio@chromium.org

Comment 3 by omrilio@chromium.org, Mar 30 2017

Owner: elizabethchiu@chromium.org
Per offline chat with +Elizabeth, she will provide with new assets.
Thanks!

Comment 4 by gkihumba@google.com, Apr 18 2017 

Any updates?

Comment 5 by elizabethchiu@chromium.org, Apr 18 2017 

I'm working on this. I will provide the assets later today.

Comment 6 by elizabethchiu@chromium.org, Apr 20 2017 

gkihumba@ Here are the new assets.
System Menu:
https://drive.google.com/open?id=0B6x6iYCtKinEd3BxelVZWGxmekk

icons names:
auto_rotation_lock
auto_rotation
portrait
landscape


Shelf:
https://drive.google.com/open?id=0B6x6iYCtKinEbHlfdkJGTzNGNTA

icons names:
auto_rotation_lock
auto_rotation

Comment 7 by elizabethchiu@chromium.org, Apr 21 2017

Cc: elizabethchiu@chromium.org
Owner: gkihumba@chromium.org

Comment 8 by warx@chromium.org, Apr 24 2017

Cc: gkihumba@chromium.org
Owner: warx@chromium.org
Status: Started (was: Assigned)
Thanks!

Comment 9 by warx@chromium.org, Apr 28 2017 

Here is the updated UI:
landscape_autorotate.png
885 KB View Download
landscape_locked.png
884 KB View Download
portrait_locked.png
858 KB View Download

Comment 10 by warx@chromium.org, Apr 28 2017

portrait_autorotate.png
860 KB View Download

Comment 11 by osh...@chromium.org, Apr 28 2017 

lg!

Comment 12 by osh...@chromium.org, Apr 28 2017 

Actually shouldn't tray use the same image?

Comment 13 by warx@chromium.org, Apr 28 2017 

Elizabeth helped pointing out an icon that is not updated. Attached is the updated one, which is reflected in ps3 in https://codereview.chromium.org/2846883006/. Thanks!
updated_system_menu_auto_rotate_icon.png
868 KB View Download

Comment 14 by warx@chromium.org, Apr 28 2017 

I got both locked icon from system menu and system tray. The assets are different. system tray svg seems have white filling.

Comment 15 by elizabethchiu@chromium.org, Apr 28 2017 

Looks good to me.
Project Member

Comment 16 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01

commit 0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01
Author: warx <warx@chromium.org>
Date: Mon May 01 22:14:20 2017

cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape and portrait.

 crbug.com/704923  #9 shows the UI implementation.

BUG= 704923 
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}

[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/ash_strings.grd
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/BUILD.gn
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_auto.1x.icon
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_auto.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_landscape.1x.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_landscape.icon
[delete] https://crrev.com/6794758842707fe09980d5495fed326413767a5f/ash/resources/vector_icons/system_menu_rotation_lock_locked.1x.icon
[delete] https://crrev.com/6794758842707fe09980d5495fed326413767a5f/ash/resources/vector_icons/system_menu_rotation_lock_locked.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_portrait.1x.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_menu_rotation_lock_portrait.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_tray_rotation_lock_auto.1x.icon
[add] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_tray_rotation_lock_auto.icon
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_tray_rotation_lock_locked.1x.icon
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/resources/vector_icons/system_tray_rotation_lock_locked.icon
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/system/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/system/rotation/tray_rotation_lock.h
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01/testing/buildbot/filters/ash_mus_unittests.filter

Comment 17 by warx@chromium.org, May 1 2017

Labels: Merge-Request-59
#16 -> request merge to M59

Comment 18 by gkihumba@google.com, May 2 2017

Labels: Merge-Approved-59
Project Member

Comment 19 by sheriffbot@chromium.org, May 2 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 34 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, May 2 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d

commit 1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d
Author: Qiang Xu <warx@chromium.org>
Date: Tue May 02 22:19:36 2017

[merge to M59] cros: Update rotation lock UI

changes:
(1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape and portrait.

 crbug.com/704923  #9 shows the UI implementation.

TBR=oshima@chromium.org
BUG= 704923 
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}
(cherry picked from commit 0eb3a02b096d72abc5f2f8f9ad6b786b39fd0c01)

Review-Url: https://codereview.chromium.org/2859663003 .
Cr-Commit-Position: refs/branch-heads/3071@{#363}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/ash_strings.grd
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/BUILD.gn
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_auto.1x.icon
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_auto.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_landscape.1x.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_landscape.icon
[delete] https://crrev.com/9704081c8286f4b6a87544eae53790889fe3e974/ash/resources/vector_icons/system_menu_rotation_lock_locked.1x.icon
[delete] https://crrev.com/9704081c8286f4b6a87544eae53790889fe3e974/ash/resources/vector_icons/system_menu_rotation_lock_locked.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_portrait.1x.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_menu_rotation_lock_portrait.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_tray_rotation_lock_auto.1x.icon
[add] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_tray_rotation_lock_auto.icon
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_tray_rotation_lock_locked.1x.icon
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/resources/vector_icons/system_tray_rotation_lock_locked.icon
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/system/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/system/rotation/tray_rotation_lock.h
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/1a3cfed4e646b679b4fe2ae30b0487bc5124cb0d/testing/buildbot/filters/ash_mus_unittests.filter

Comment 21 by warx@chromium.org, May 2 2017

Status: Fixed (was: Started)

Comment 22 by gkihumba@google.com, Jun 16 2017

Labels: -Merge-Review-59

Comment 23 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment