Issue metadata
Sign in to add a comment
|
DEPS publishing formats dict recursedeps incorrectly casuing recursive deps to not be synced on release tags. |
||||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) git checkout origin/master (2) gclient sync -D -R -f --with_branch_heads --nohooks (3) ls third_party/swiftshader/third_party/pnacl-subzero/ (4) git checkout 59.0.3047.4 (5) gclient sync -D -R -f --with_branch_heads --nohooks (6) ls third_party/swiftshader/third_party/pnacl-subzero/ What is the expected result? Sources to be present and synced to release tag. What happens instead? Sources removed (or left unchanged if -f is omitted). The problem is that recursive deps (recursedeps entires in main DEPS files) that are lists when published have their entires reversed, and gclient expect specific order to work (gclient.py:628). This is turn causes those recursive deps to not be synced in release tags checkouts, depending on call either removing that dir completely (gclient sync -D -f) of just leaving at whatever revision it was checked out previously.
,
Mar 24 2017
Manually reversing order in those entries and syncing again restores that dir in checkout properly.
,
Mar 24 2017
I think, it's a duplicate of https://bugs.chromium.org/p/chromium/issues/detail?id=685433&desc=2
,
Mar 24 2017
,
Mar 28 2017
,
Mar 31 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mharanc...@opera.com
, Mar 24 2017